Skip to content
This repository was archived by the owner on Dec 27, 2022. It is now read-only.
This repository was archived by the owner on Dec 27, 2022. It is now read-only.

Request: yank minimal-versions incompliant releases #60

@CAD97

Description

@CAD97

Specifically, 0.5.0 through 0.5.6 all fail with a -Z minimal-versions lockfile. 0.5.7 works, and 0.5.9 is the first 0.5 series version with a tag and using syn/quote 1.0.

notes

Interestingly, changing between proc-macro-hack 0.5.6 and 0.5.7 only changes the version of proc-macro-hack and doesn't impact the rest of the tree. It seems to be the only difference is whether the default feature set is used.

Honestly, it might make sense to yank so the minimal 0.5 version is 0.5.9 so the people still trying to use minimal-versions don't end up dealing with pre-1.0 syn/quote via proc-macro-hack.

This isn't urgent nor even blocking minimal-versions correctness for any of my crates; I've just decided not to enable ahash's compile-time-random support, which dropped proc-macro-hack out of the dependency tree of the crate where I found this out.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions