test: ensure be able to install duckdb extensions on release version #1586
Conversation
|
The commit 1d9cba2 is on top of version 1.3.3, and we can confirm that the tests fails as expected. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1586 +/- ##
===========================================
- Coverage 63.61% 53.38% -10.24%
===========================================
Files 123 151 +28
Lines 5266 10318 +5052
===========================================
+ Hits 3350 5508 +2158
- Misses 1916 4810 +2894 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } | ||
|
|
||
| # Skip on CRAN, but run on R-universe | ||
| skip_on_cran_except_r_universe <- function() { |
There was a problem hiding this comment.
Nice! I didn't realize R-Universe testing doesn't set NOT_CRAN though thinking about it I guess this should have been intuitive. Nice work with the MY_UNIVERSE flag.
There was a problem hiding this comment.
Yes, R-universe intentionally provides checks similar to CRAN, so it should only be possible to detect by this environment variable.
Some Rust-based packages I manage detect this environment variable and download binaries from external sources that are not permitted by CRAN.
https://github.com/PRQL/prqlc-r/blob/0cc594f157d64e52905dfa60d5fa10c857f6a4b1/configure#L8-L9
| skip_on_dev_version() | ||
| skip_on_cran_except_r_universe() | ||
|
|
||
| expect_no_error(sql("INSTALL icu")) |
|
Thanks! |
4 participants
Related to #1517