Skip to content

--from-pr does not respect alt_location in a patches dict #4964

@ocaisa

Description

@ocaisa

For a dict such as that contained in

...
components = [
    ('flux-core', '0.76.0', {
        'easyblock': 'ConfigureMake',
        'source_urls': ['https://github.com/flux-framework/flux-core/releases/download/v%(version)s/'],
        'sources': [SOURCELOWER_TAR_GZ],
        'patches': [
            {'name': 'flux-core-0.76.0_remove_some_tests.patch', 'alt_location': 'flux-core'},
            {'name': 'flux-core-0.76.0_disable_sha1_test.patch', 'alt_location': 'flux-core'},
        ],
        'checksums': [
            'c28d271a50b4065c2399af844a51d2b0e7ab3fa262f4bbf15a4c1115cd6fe77c',
            '3c71d6b79a41d70ffc2c3942f87609e231792e3a5bfacfda72d76fb2d28c4aea',
            'a3cbbabe8e7e88e6c17cf9079abc004705074c759b8bb12b8dec853210df86f2',
        ],
        'start_dir': '%(namelower)s-%(version)s',
        'runtest': 'check',
...

--from-pr does not honor the alternative location and fails with an error like

== FAILED: Installation ended unsuccessfully: Couldn't find file flux-core-0.76.0_remove_some_tests.patch anywhere, and downloading it didn't work either... Paths attempted (in order): /tmp/eb-v1q4evkp/files_pr22979/f/Flux/f/Flux/flux-core-0.76.0_remove_some_tests.patch, /tmp/eb-v1q4evkp/files_pr22979/f/Flux/Flux/flux-core-0.76.0_remove_some_tests.patch, /tmp/eb-v1q4evkp/files_pr22979/f/Flux/flux-core-0.76.0_remove_some_tests.patch, /cvmfs/software.eessi.io/versions/2023.06/software/linux/x86_64/intel/icelake/software/EasyBuild/5.1.1/easybuild/easyconfigs/f/Flux/flux-core-0.76.0_remove_some_tests.patch, /cvmfs/software.eessi.io/versions/2023.06/software/linux/x86_64/intel/icelake/software/EasyBuild/5.1.1/easybuild/easyconfigs/Flux/flux-core-0.76.0_remove_some_tests.patch, /cvmfs/software.eessi.io/versions/2023.06/software/linux/x86_64/intel/icelake/software/EasyBuild/5.1.1/easybuild/easyconfigs/flux-core-0.76.0_remove_some_tests.patch, /tmp/eb-v1q4evkp/files_pr22979/f/Flux/flux-core-0.76.0_remove_some_tests.patch, /tmp/eb-v1q4evkp/files_pr22979/Flux/flux-core-0.76.0_remove_some_tests.patch, /tmp/eb-v1q4evkp/files_pr22979/flux-core-0.76.0_remove_some_tests.patch, /cvmfs/software.eessi.io/versions/2023.06/software/linux/x86_64/intel/icelake/software/EasyBuild/5.1.1/easybuild/easyconfigs/f/Flux/flux-core-0.76.0_remove_some_tests.patch, /cvmfs/software.eessi.io/versions/2023.06/software/linux/x86_64/intel/icelake/software/EasyBuild/5.1.1/easybuild/easyconfigs/Flux/flux-core-0.76.0_remove_some_tests.patch, /cvmfs/software.eessi.io/versions/2023.06/software/linux/x86_64/intel/icelake/software/EasyBuild/5.1.1/easybuild/easyconfigs/flux-core-0.76.0_remove_some_tests.patch, /tmp/ocaisa/easybuild/sources/f/Flux/flux-core-0.76.0_remove_some_tests.patch, /tmp/ocaisa/easybuild/sources/Flux/flux-core-0.76.0_remove_some_tests.patch, /tmp/ocaisa/easybuild/sources/flux-core-0.76.0_remove_some_tests.patch, https://sources.easybuild.io/f/Flux/flux-core-0.76.0_remove_some_tests.patch  (took 0 secs)
== Results of the build can be found in the log file(s) /tmp/eb-v1q4evkp/easybuild-Flux-0.76.0-20250729.160058.aSRUo.log

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions