Add fr locale #540
Add fr locale #540
Conversation
✅ Deploy Preview for easyops-cn-docusaurus-search-local ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughAdds a new French locale JSON file for the Docusaurus search plugin, introducing French translations for SearchBar and SearchPage i18n keys. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
docusaurus-search-local/locales/fr.json (3)
3-3: Prefer “Voir tous les résultats”.More idiomatic and closer to the English intent of “see all results.”
Apply:
- "theme.SearchBar.seeAll": "Voir les résultats", + "theme.SearchBar.seeAll": "Voir tous les résultats",
5-7: Minor phrasing and French quotes.
- “dans la catégorie” reads more natural than “pour la catégorie”.
- Consider French guillemets around placeholders; it’s common in FR UI strings.
Apply:
- "theme.SearchBar.searchInContext": "Voir les résultats pour la catégorie \"{context}\"", - "theme.SearchBar.seeAllOutsideContext": "Voir les résultats en dehors de la catégorie \"{context}\"", - "theme.SearchPage.existingResultsTitle": "Résultats pour la recherche \"{query}\"", + "theme.SearchBar.searchInContext": "Voir les résultats dans la catégorie « {context} »", + "theme.SearchBar.seeAllOutsideContext": "Voir tous les résultats hors de la catégorie « {context} »", + "theme.SearchPage.existingResultsTitle": "Résultats pour « {query} »",
10-10: Style consistency.Consider “Aucun résultat trouvé” to align with shorter SearchBar text, unless other locales prefer the full past-tense phrasing.
Apply:
- "theme.SearchPage.noResultsText": "Aucun résultat n'a été trouvé", + "theme.SearchPage.noResultsText": "Aucun résultat trouvé",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
docusaurus-search-local/locales/fr.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - easyops-cn-docusaurus-search-local
- GitHub Check: Header rules - easyops-cn-docusaurus-search-local
- GitHub Check: Pages changed - easyops-cn-docusaurus-search-local
🔇 Additional comments (3)
docusaurus-search-local/locales/fr.json (3)
1-12: LGTM overall — solid FR locale addition.Keys and placeholders look consistent; JSON is valid.
2-12: Parity check with other locales.Ensure no keys are missing vs en.json (e.g., potential “cancel”, “loading”, etc., if they exist upstream).
If the script above reports missing keys, I can propose a follow-up patch.
9-9: Pluralization format is consistent—no action requiredVerified that the French entry in docusaurus-search-local/locales/fr.json (line 9) uses the same pipe-separated singular|plural format as German (de.json) and matches the plugin’s handling of
theme.SearchPage.documentsFound.plurals. No other locale files use a two-form pipe pattern because they require only a single message. The current FR string aligns with the repository convention.
1 participant
Add translation for French
Summary by CodeRabbit