Skip to content

Commit e2150f5

Browse files
committed
feat(update): disable subcmd in different provider
disable subcmd in different provider Signed-off-by: ysicing <[email protected]>
1 parent 8ecfb30 commit e2150f5

File tree

6 files changed

+31
-16
lines changed

6 files changed

+31
-16
lines changed

cmd/manage/renewtls.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ func NewRenewTLS(f factory.Factory) *cobra.Command {
1616
var force bool
1717
rtls := &cobra.Command{
1818
Use: "renewtls",
19-
Short: "renew qucheng tls domain",
19+
Short: "renew tls domain",
2020
Aliases: []string{"rtls", "rt"},
2121
Version: "1.2.11",
2222
RunE: func(cmd *cobra.Command, args []string) error {

cmd/platform.go

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,22 +10,27 @@ import (
1010
"github.com/easysoft/qcadmin/cmd/app"
1111
"github.com/easysoft/qcadmin/cmd/manage"
1212
"github.com/easysoft/qcadmin/cmd/quickon"
13+
"github.com/easysoft/qcadmin/internal/app/config"
1314
"github.com/easysoft/qcadmin/internal/pkg/util/factory"
15+
"github.com/easysoft/qcadmin/internal/pkg/util/kutil"
1416
"github.com/spf13/cobra"
1517
)
1618

1719
func newCmdApp(f factory.Factory) *cobra.Command {
1820
appCmd := &cobra.Command{
1921
Use: "app",
20-
Short: "Manage Quickon applications",
21-
Version: "20230330",
22+
Short: "Manage applications",
23+
Version: "20230906",
24+
}
25+
cfg, _ := config.LoadConfig()
26+
if cfg == nil || !cfg.Quickon.DevOps {
27+
appCmd.AddCommand(app.NewCmdAppExec(f))
28+
appCmd.AddCommand(app.NewCmdAppGet(f))
29+
appCmd.AddCommand(app.NewCmdAppLogs(f))
30+
appCmd.AddCommand(app.NewCmdAppInstall(f))
31+
appCmd.AddCommand(app.NewCmdAppMarket(f))
2232
}
23-
appCmd.AddCommand(app.NewCmdAppExec(f))
24-
appCmd.AddCommand(app.NewCmdAppGet(f))
25-
appCmd.AddCommand(app.NewCmdAppLogs(f))
2633
appCmd.AddCommand(app.NewCmdAppList(f))
27-
appCmd.AddCommand(app.NewCmdAppInstall(f))
28-
appCmd.AddCommand(app.NewCmdAppMarket(f))
2934
return appCmd
3035
}
3136

@@ -41,13 +46,18 @@ func newCmdPlatform(f factory.Factory) *cobra.Command {
4146
platformCmd.AddCommand(quickon.InitCommand(f))
4247
platformCmd.AddCommand(quickon.UninstallCommand(f))
4348
platformCmd.AddCommand(manage.NewCmdPlugin(f))
44-
platformCmd.AddCommand(manage.NewResetPassword(f))
45-
platformCmd.AddCommand(manage.NewRenewTLS(f))
4649
gdbCmd := &cobra.Command{
4750
Use: "gdb",
4851
Short: "Manage Global Database",
4952
}
5053
gdbCmd.AddCommand(manage.NewCmdGdbList(f))
5154
platformCmd.AddCommand(gdbCmd)
55+
cfg, _ := config.LoadConfig()
56+
if cfg == nil || !cfg.Quickon.DevOps {
57+
platformCmd.AddCommand(manage.NewResetPassword(f))
58+
}
59+
if cfg == nil || kutil.IsLegalDomain(cfg.Domain) {
60+
platformCmd.AddCommand(manage.NewRenewTLS(f))
61+
}
5262
return platformCmd
5363
}

cmd/root.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import (
1515
"github.com/easysoft/qcadmin/common"
1616
"github.com/easysoft/qcadmin/internal/pkg/util/factory"
1717
"github.com/easysoft/qcadmin/internal/pkg/util/log"
18+
"github.com/ergoapi/util/color"
1819
"github.com/ergoapi/util/excmd"
1920
mcobra "github.com/muesli/mango-cobra"
2021
"github.com/muesli/roff"
@@ -74,7 +75,9 @@ func BuildRoot(f factory.Factory) *cobra.Command {
7475
rootCmd.AddCommand(newCmdDebug(f))
7576

7677
// Deprecated commands, will be removed in the future
77-
rootCmd.AddCommand(newCmdApp(f))
78+
deprecatedAppCommand := newCmdApp(f)
79+
deprecatedAppCommand.Deprecated = fmt.Sprintf("use %s instead", color.SGreen("%s platform app", os.Args[0]))
80+
rootCmd.AddCommand(deprecatedAppCommand)
7881

7982
args := os.Args
8083
if len(args) > 1 {
@@ -106,8 +109,8 @@ func BuildRoot(f factory.Factory) *cobra.Command {
106109
func NewRootCmd(f factory.Factory) *cobra.Command {
107110
return &cobra.Command{
108111
Use: "qcadmin",
109-
SilenceUsage: true,
110-
SilenceErrors: true,
112+
// SilenceUsage: true,
113+
// SilenceErrors: true,
111114
Short: "Easily bootstrap a secure control plane for QuCheng",
112115
Aliases: []string{"q"},
113116
Example: common.RootTPl,

common/vars.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ var (
4242

4343
var (
4444
ValidPrefixes = []string{"qcadmin", "qc"}
45-
ValidDomainSuffix = []string{"corp.cc"}
45+
// ValidDomainSuffix valid domain suffix, haogs.cn is deprecated
46+
ValidDomainSuffix = []string{"corp.cc", "haogs.cn"}
4647
)
4748

4849
var CloudAPI = []cloudAPIS{

internal/pkg/util/httptls/httptls.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import (
1717
"github.com/easysoft/qcadmin/common"
1818
"github.com/easysoft/qcadmin/internal/app/config"
1919
qcexec "github.com/easysoft/qcadmin/internal/pkg/util/exec"
20+
"github.com/easysoft/qcadmin/internal/pkg/util/kutil"
2021
"github.com/easysoft/qcadmin/internal/pkg/util/log"
2122
)
2223

@@ -25,7 +26,7 @@ func CheckReNewCertificate(force bool) (err error) {
2526
log := log.GetInstance()
2627
cfg, _ := config.LoadConfig()
2728
domain := cfg.Domain
28-
if strings.HasSuffix(domain, "haogs.cn") || strings.HasSuffix(domain, "corp.cc") {
29+
if kutil.IsLegalDomain(domain) {
2930
needRenew := false
3031
if force {
3132
needRenew = true

pkg/quickon/quickon.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -514,7 +514,7 @@ func (m *Meta) UnInstall() error {
514514
repoCleanArgs := []string{"experimental", "helm", "repo-del"}
515515
_ = qcexec.Command(os.Args[0], repoCleanArgs...).Run()
516516
m.Log.Done("uninstall helm repo success")
517-
if strings.HasSuffix(cfg.Domain, "haogs.cn") || strings.HasSuffix(cfg.Domain, "corp.cc") {
517+
if kutil.IsLegalDomain(cfg.Domain) {
518518
m.Log.Infof("clean domain %s", cfg.Domain)
519519
if err := qcexec.Command(os.Args[0], "exp", "tools", "domain", "clean", cfg.Domain).Run(); err != nil {
520520
m.Log.Warnf("clean domain %s failed, reason: %v", cfg.Domain, err)

0 commit comments

Comments
 (0)