[#301] Remove 'timespec' from 'Duration'

Author: elBoberido

iceoryx2-bb/cxx/include/iox2/bb/duration.hpp

@@ -20,7 +20,6 @@
 #include "iox2/legacy/type_traits.hpp"
 
 #include <cmath>
-#include <ctime>
 
 namespace iox2 {
 namespace bb {
@@ -143,15 +142,6 @@ class Duration {
     static constexpr auto zero() noexcept -> Duration;
     // END CREATION FROM STATIC FUNCTIONS
 
-    // BEGIN CONSTRUCTORS AND ASSIGNMENT
-
-    /// @brief Construct a Duration object from timespec
-    /// @param[in] value as timespec
-    // AXIVION Next Line AutosarC++19_03-A8.4.7 : Argument is larger than two words
-    constexpr explicit Duration(const struct timespec& value) noexcept;
-
-    // END CONSTRUCTORS AND ASSIGNMENT
-
     // BEGIN COMPARISON
     // AXIVION DISABLE STYLE AutosarC++19_03-A8.4.7 : Each argument is larger than two words
     friend constexpr auto operator==(const Duration& lhs, const Duration& rhs) noexcept -> bool;
@@ -263,9 +253,6 @@ class Duration {
     /// @note The remaining microseconds are truncated, similar to the casting behavior of a float to an int.
     constexpr auto subsec_millis() const noexcept -> uint32_t;
 
-    /// @brief converts duration in a timespec c struct
-    constexpr auto timespec() const noexcept -> struct timespec;
-
     // END CONVERSION
 
     // AXIVION DISABLE STYLE AutosarC++19_03-A3.9.1 : Use of unsigned long long int in user-defined literals is enforced by the standard
@@ -507,11 +494,6 @@ constexpr auto Duration::from_days(const T value) noexcept -> Duration {
     return Duration { static_cast<Duration::SecondsT>(clamped_value * SECS_PER_DAY), 0U };
 }
 
-// AXIVION Next Construct AutosarC++19_03-A8.4.7 : Argument is larger than two words
-constexpr Duration::Duration(const struct timespec& value) noexcept
-    : Duration(static_cast<SecondsT>(value.tv_sec), static_cast<NanosecondsT>(value.tv_nsec)) {
-}
-
 constexpr auto Duration::to_nanoseconds() const noexcept -> uint64_t {
     constexpr SecondsT MAX_SECONDS_BEFORE_OVERFLOW { std::numeric_limits<uint64_t>::max()
                                                      / static_cast<uint64_t>(NANOSECS_PER_SEC) };
@@ -603,23 +585,8 @@ constexpr auto Duration::operator+(const Duration& rhs) const noexcept -> Durati
     return sum;
 }
 
-constexpr auto Duration::timespec() const noexcept -> struct timespec {
-    using SecType = decltype(std::declval<struct timespec>().tv_sec);
-    using NsecType = decltype(std::declval<struct timespec>().tv_nsec);
-
-    static_assert(sizeof(uint64_t) >= sizeof(SecType), "casting might alter result");
-    if (this->m_seconds > static_cast<uint64_t>(std::numeric_limits<SecType>::max())) {
-        return { std::numeric_limits<SecType>::max(), NANOSECS_PER_SEC - 1U };
-    }
-
-    const auto tv_sec = static_cast<SecType>(this->m_seconds);
-    const auto tv_nsec = static_cast<NsecType>(this->m_nanoseconds);
-    return { tv_sec, tv_nsec };
-}
-
 // AXIVION Next Construct AutosarC++19_03-A8.4.7 : Argument is larger than two words
-constexpr auto
-Duration::operator+=(const Duration& rhs) noexcept -> Duration& {
+constexpr auto Duration::operator+=(const Duration& rhs) noexcept -> Duration& {
     *this = *this + rhs;
     return *this;
 }

iceoryx2-bb/cxx/tests/src/duration_tests.cpp

@@ -18,7 +18,6 @@
 #include <gmock/gmock.h>
 #include <gtest/gtest.h>
 
-#include <ctime>
 #include <iostream>
 #include <limits>
 #include <ostream>
@@ -159,61 +158,6 @@ TEST(Duration_test, ConstructDurationWithOneNanosecondResultsNotInZeroNanosecond
     EXPECT_THAT(sut.to_nanoseconds(), Eq(EXPECTED_DURATION_IN_NANOSECONDS));
 }
 
-TEST(Duration_test, ConstructFromTimespecWithZeroValue) {
-    ::testing::Test::RecordProperty("TEST_ID", "0360ae1d-b7e7-4b07-b515-fdc82703d16f");
-    constexpr uint64_t SECONDS { 0U };
-    constexpr uint64_t NANOSECONDS { 0U };
-    constexpr Duration EXPECTED_DURATION = create_duration(SECONDS, NANOSECONDS);
-
-    timespec ts = {}; // NOLINT
-    ts.tv_sec = SECONDS;
-    ts.tv_nsec = NANOSECONDS;
-
-    Duration sut { ts };
-    EXPECT_THAT(sut, Eq(EXPECTED_DURATION));
-}
-
-TEST(Duration_test, ConstructFromTimespecWithValueLessThanOneSecond) {
-    ::testing::Test::RecordProperty("TEST_ID", "3cc49b4b-2bdf-491a-9015-9e8d769ba113");
-    constexpr uint64_t SECONDS { 0U };
-    constexpr uint64_t NANOSECONDS { 456U };
-    constexpr Duration EXPECTED_DURATION = create_duration(SECONDS, NANOSECONDS);
-
-    timespec value = {};
-    value.tv_sec = SECONDS;
-    value.tv_nsec = NANOSECONDS;
-
-    Duration sut { value };
-    EXPECT_THAT(sut, Eq(EXPECTED_DURATION));
-}
-
-TEST(Duration_test, ConstructFromTimespecWithValueMoreThanOneSecond) {
-    ::testing::Test::RecordProperty("TEST_ID", "d8a165e4-3117-4897-bd16-3c5a0333c1b5");
-    constexpr uint64_t SECONDS { 73U };
-    constexpr uint64_t NANOSECONDS { 456U };
-    constexpr Duration EXPECTED_DURATION = create_duration(SECONDS, NANOSECONDS);
-
-    timespec value = {};
-    value.tv_sec = SECONDS;
-    value.tv_nsec = NANOSECONDS;
-
-    Duration sut { value };
-    EXPECT_THAT(sut, Eq(EXPECTED_DURATION));
-}
-
-TEST(Duration_test, ConstructFromTimespecWithMaxValue) {
-    ::testing::Test::RecordProperty("TEST_ID", "d160d324-914f-4a66-ac96-17828442d4bd");
-    constexpr uint64_t SECONDS { std::numeric_limits<DurationAccessor::SecondsT>::max() };
-    constexpr uint64_t NANOSECONDS { NANOSECS_PER_SECOND - 1U };
-
-    timespec ts = {}; // NOLINT
-    ts.tv_sec = static_cast<time_t>(SECONDS);
-    ts.tv_nsec = static_cast<long>(NANOSECONDS);
-
-    Duration sut { ts };
-    EXPECT_THAT(sut, Eq(DurationAccessor::max()));
-}
-
 // END CONSTRUCTOR TESTS
 
 // BEGIN CREATION FROM LITERAL TESTS
@@ -800,69 +744,6 @@ TEST(Duration_test, ConvertNanoecondsFromMaxDurationResultsInSaturation) {
     EXPECT_THAT(sut.to_nanoseconds(), Eq(std::numeric_limits<uint64_t>::max()));
 }
 
-TEST(Duration_test, ConvertTimespecFromZeroDuration) {
-    ::testing::Test::RecordProperty("TEST_ID", "6a049ba6-885e-48c0-a9e8-3de6fa9a79f2");
-    constexpr int64_t SECONDS { 0 };
-    constexpr int64_t NANOSECONDS { 0 };
-
-    auto duration = create_duration(SECONDS, NANOSECONDS);
-
-    const timespec sut = duration.timespec();
-
-    EXPECT_THAT(sut.tv_sec, Eq(SECONDS));
-    EXPECT_THAT(sut.tv_nsec, Eq(NANOSECONDS));
-}
-
-TEST(Duration_test, ConvertTimespecFromDurationLessThanOneSecond) {
-    ::testing::Test::RecordProperty("TEST_ID", "d20435da-4585-44d9-9be7-24eb22c3ca85");
-    constexpr int64_t SECONDS { 0 };
-    constexpr int64_t NANOSECONDS { 55 };
-
-    auto duration = create_duration(SECONDS, NANOSECONDS);
-
-    const timespec sut = duration.timespec();
-
-    EXPECT_THAT(sut.tv_sec, Eq(SECONDS));
-    EXPECT_THAT(sut.tv_nsec, Eq(NANOSECONDS));
-}
-
-TEST(Duration_test, ConvertTimespecFromDurationMoreThanOneSecond) {
-    ::testing::Test::RecordProperty("TEST_ID", "1b298bc3-3a0b-48a2-8d9c-1ee03dea925c");
-    constexpr int64_t SECONDS { 44 };
-    constexpr int64_t NANOSECONDS { 55 };
-
-    auto duration = create_duration(SECONDS, NANOSECONDS);
-
-    const timespec sut = duration.timespec();
-
-    EXPECT_THAT(sut.tv_sec, Eq(SECONDS));
-    EXPECT_THAT(sut.tv_nsec, Eq(NANOSECONDS));
-}
-
-TEST(Duration_test, ConvertTimespecFromDurationResultsNotYetInSaturation) {
-    ::testing::Test::RecordProperty("TEST_ID", "70f11b99-78ec-442a-aefe-4dd9152b7903");
-    constexpr int64_t SECONDS { std::numeric_limits<decltype(timespec::tv_sec)>::max() };
-    constexpr int64_t NANOSECONDS { NANOSECS_PER_SECOND - 1U };
-
-    auto duration = create_duration(SECONDS, NANOSECONDS);
-
-    const timespec sut = duration.timespec();
-
-    EXPECT_THAT(sut.tv_sec, Eq(SECONDS));
-    EXPECT_THAT(sut.tv_nsec, Eq(NANOSECONDS));
-}
-
-TEST(Duration_test, ConvertTimespecFromMaxDurationResultsInSaturation) {
-    ::testing::Test::RecordProperty("TEST_ID", "3bf4bb34-46f3-4889-84f5-9220b32fff73");
-    constexpr int64_t SECONDS { std::numeric_limits<decltype(timespec::tv_sec)>::max() };
-    constexpr int64_t NANOSECONDS { NANOSECS_PER_SECOND - 1U };
-
-    const timespec sut = DurationAccessor::max().timespec();
-
-    EXPECT_THAT(sut.tv_sec, Eq(SECONDS));
-    EXPECT_THAT(sut.tv_nsec, Eq(NANOSECONDS));
-}
-
 // END CONVERSION FUNCTION TESTS
 
 // BEGIN SUBSECONDS ACCESS TESTS