Skip to content

Conversation

@elBoberido
Copy link
Member

@elBoberido elBoberido commented Nov 30, 2025

Notes for Reviewer

This PR moves iox2/legacy/into.hpp and its dependencies to iox2/bb/into.hpp. Furthermore, the namespace is adjusted to iox2::bb and the clang-tidy warnings are fixed.

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
  • [~] Tests follow the best practice for testing
  • [~] Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer
  • All checks have passed (except task-list-completed)

PR Reviewer Reminder

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

References

Closes #

@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

❌ Patch coverage is 61.33333% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.41%. Comparing base (e0a0541) to head (4a82879).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
iceoryx2-cxx/src/service.cpp 14.28% 3 Missing and 3 partials ⚠️
iceoryx2-cxx/include/iox2/listener.hpp 0.00% 5 Missing ⚠️
iceoryx2-cxx/include/iox2/publisher.hpp 33.33% 4 Missing ⚠️
iceoryx2-cxx/src/node.cpp 42.85% 3 Missing and 1 partial ⚠️
iceoryx2-cxx/src/waitset.cpp 71.42% 3 Missing and 1 partial ⚠️
iceoryx2-cxx/include/iox2/active_request.hpp 25.00% 3 Missing ⚠️
iceoryx2-cxx/include/iox2/client.hpp 40.00% 3 Missing ⚠️
iceoryx2-cxx/include/iox2/server.hpp 0.00% 2 Missing ⚠️
iceoryx2-cxx/include/iox2/subscriber.hpp 0.00% 2 Missing ⚠️
iceoryx2-cxx/src/attribute_verifier.cpp 0.00% 2 Missing ⚠️
... and 21 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1206      +/-   ##
==========================================
+ Coverage   78.39%   78.41%   +0.01%     
==========================================
  Files         411      411              
  Lines       41008    41006       -2     
  Branches     1095     1095              
==========================================
+ Hits        32149    32153       +4     
+ Misses       8026     8020       -6     
  Partials      833      833              
Flag Coverage Δ
CPP 72.79% <61.33%> (-0.01%) ⬇️
Rust 78.22% <60.54%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
iceoryx2-bb/cxx/include/iox2/bb/into.hpp 100.00% <100.00%> (ø)
...-bb/cxx/include/iox2/legacy/cli/option_manager.inl 73.33% <ø> (ø)
.../include/iox2/legacy/detail/std_chrono_support.inl 100.00% <100.00%> (ø)
.../include/iox2/legacy/detail/std_string_support.inl 100.00% <100.00%> (ø)
...-bb/cxx/include/iox2/legacy/std_string_support.hpp 100.00% <ø> (ø)
iceoryx2-cxx/include/iox2/enum_translation.hpp 48.07% <100.00%> (ø)
iceoryx2-cxx/include/iox2/port_factory_client.hpp 90.90% <100.00%> (ø)
...ceoryx2-cxx/include/iox2/port_factory_listener.hpp 100.00% <ø> (ø)
...eoryx2-cxx/include/iox2/port_factory_publisher.hpp 100.00% <ø> (ø)
iceoryx2-cxx/include/iox2/port_factory_reader.hpp 100.00% <ø> (ø)
... and 39 more

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elBoberido elBoberido force-pushed the iox2-301-move-into-files-to-iox2-bb branch from eb1a90a to 54141ea Compare November 30, 2025 20:51
@elBoberido elBoberido changed the base branch from main to iox2-301-align-copyright-header-of-new-files-with-iceoryx2-schema November 30, 2025 20:54
@elBoberido elBoberido changed the title [WIP] [Based on #1205] [#301] Move 'into' files to 'iox2/bb' [Stacked PR] [Based on #1205] [#301] Move 'into' files to 'iox2/bb' Nov 30, 2025
@elBoberido elBoberido marked this pull request as draft November 30, 2025 21:10
@elfenpiff elfenpiff self-requested a review December 1, 2025 06:33
Copy link
Contributor

@elfenpiff elfenpiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow our naming style strictly without exceptions.

Base automatically changed from iox2-301-align-copyright-header-of-new-files-with-iceoryx2-schema to main December 1, 2025 17:40
@elBoberido elBoberido marked this pull request as ready for review December 1, 2025 18:00
@elBoberido elBoberido force-pushed the iox2-301-move-into-files-to-iox2-bb branch from 54141ea to 4a82879 Compare December 1, 2025 18:00
@elBoberido elBoberido changed the title [Stacked PR] [Based on #1205] [#301] Move 'into' files to 'iox2/bb' [#301] Move 'into' files to 'iox2/bb' Dec 1, 2025
@elBoberido elBoberido requested a review from elfenpiff December 1, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants