Skip to content

Commit 7398855

Browse files
Create Req Inspection Template in Folders - fixes
Resolves: #106
1 parent 120e8e5 commit 7398855

File tree

3 files changed

+87
-133
lines changed

3 files changed

+87
-133
lines changed

process/folder_templates/features/feature_name/requirements/chklst_req_inspection.rst

Lines changed: 40 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,16 +24,26 @@
2424
The above directive must be updated according to your Feature.
2525

2626
- Modify ``Your Feature Name`` to be your Feature Name
27-
- Modify ``id`` to be your Feature Name in upper snake case preceded by ``doc__`` and followed by ``_req_inspection``
27+
- Modify ``id`` to be your Feature Name in lower snake case preceded by ``doc__`` and followed by ``_req_inspection``
2828
- Adjust ``status`` to be ``valid``
2929
- Adjust ``safety`` and ``tags`` according to your needs
3030

31-
[Your Feature Name] Requirement Inspection Checklist
32-
======================================================
31+
Requirement Inspection Checklist
32+
================================
3333

3434
**Purpose**
35+
3536
The purpose of this requirement inspection checklist is to collect the topics to be checked during requirements inspection.
3637

38+
**Conduct**
39+
40+
As described in the concept :need:`doc_concept__wp_inspections` the following "inspection roles" are expected to be filled:
41+
42+
- author: these are the persons who did the last commits on the requirements in scope (can be derived from version mgt tool)
43+
- reviewer: these are all persons committing into this inspection document or giving a pull request verdict on it (can be derived from version mgt tool)
44+
- moderator: only needed for conflict resolution between author and reviewers, is the safety manager, security manager or quality manager called in as a reviewer (can be derived from version mgt tool)
45+
- test expert: <one of the reviewers explicitly named here, to cover REQ_08_01 as described>
46+
3747
**Checklist**
3848

3949
.. list-table:: Feature Requirement Inspection Checklist
@@ -47,7 +57,7 @@
4757
- Remarks
4858
- Issue link
4959
* - REQ_01_01
50-
- Is the requirement sentence template used?
60+
- Is the requirement formulation template used?
5161
- see :need:`gd_temp__req_formulation`, this includes the use of "shall".
5262
-
5363
-
@@ -84,7 +94,7 @@
8494
-
8595
* - REQ_03_01
8696
- For stakeholder requirements: Is the *rationale* correct?
87-
- Rationales explain why the top level requirements were invented. Do those cover the requirement?
97+
- Rationales explain why the top level requirements were created. Do those cover the requirement?
8898
-
8999
-
90100
-
@@ -101,19 +111,19 @@
101111
-
102112
-
103113
* - REQ_05_01
104-
- Do the software requirements consider *timing constraints of the parent requirement*?
105-
- This bullet point encourages to think about timing constraints even if those are not explicitly mentioned in the parent requirement. If the reviewer of a requirement already knows or suspects that the implementation will be time consuming, one should think of the expectation of a "user".
114+
- Do the software requirements consider *timing constraints*?
115+
- This bullet point encourages to think about timing constraints even if those are not explicitly mentioned in the parent requirement. If the reviewer of a requirement already knows or suspects that the code execution will be consuming a lot of time, one should think of the expectation of a "user".
106116
-
107117
-
108118
-
109119
* - REQ_06_01
110-
- Does the Requirement consider *external interfaces*?
120+
- Does the requirement consider *external interfaces*?
111121
- The SW platform's external interfaces (to the user) are defined in the Feature Architecture, so the Feature and Component Requirements should determine the data consumed and set on these interfaces. Are output values completely defined?
112122
-
113123
-
114124
-
115125
* - REQ_07_01
116-
- Is the *ASIL Attribute* set correctly?
126+
- Is the *ASIL attribute* set correctly?
117127
- Derived requirements are checked automatically, see :need:`gd_req__req_linkage_safety`. But for the top level requirements this needs to be checked for correctness. Also AoU from external components need check for correct ASIL as those are the "origin" of safety requirements towards the SW platform.
118128
-
119129
-
@@ -126,7 +136,7 @@
126136
-
127137
* - REQ_08_01
128138
- Is the requirement *verifiable*?
129-
- Expectation is that at the time of the inspection already tests are created for the requirement. This can be checked via traces, but also :need:`gd_req__req_attr_test_covered` shows this. In case the requirement is not mature enough at the time of inspection (i.e. missing test cases), a test expert should be invited to the Pull-Request review to explicitly check this item.
139+
- If at the time of the inspection already tests are created for the requirement, the answer is yes. This can be checked via traces, but also :need:`gd_req__req_attr_test_covered` shows this. In case the requirement is not sufficiently traced to test cases already, a test expert is invited to the inspection to give his opinion whether the requirement is formulated in a way that supports test development and the available test infrastructure is sufficient to perform the test.
130140
-
131141
-
132142
-
@@ -148,13 +158,31 @@
148158
The above checklist entries must be filled according to your component requirements in scope.
149159
Also the need links mentioned in the checklist must be renamed to PROCESS_<old id> to point to the process documentation.
150160

151-
The following (valid) requirements are in the scope of this inspection:
161+
Note: If a Review ID is not applicable for your requirement, then state ""n/a" in status and comment accordingly in remarks. For example "no stakeholder requirement (no rationale needed)"
162+
163+
The following requirements with "inspected" tag set are in the scope of this inspection:
152164

153165
.. needtable::
154-
:filter: "feature_name" in docname and "requirements" in docname and docname is not None
166+
:filter: "feature_name" in docname and "requirements" in docname and docname is not None and status == "valid"
155167
:style: table
156168
:types: feat_req
157169
:tags: feature_name
158170
:columns: id;status;tags
159171
:colwidths: 25,25,25
160172
:sort: title
173+
174+
And also the following AoUs with "inspected" tag set:
175+
176+
.. needtable::
177+
:filter: "feature_name" in docname and "requirements" in docname and docname is not None and status == "valid"
178+
:style: table
179+
:types: aou_req
180+
:tags: feature_name
181+
:columns: id;status;tags
182+
:colwidths: 25,25,25
183+
:sort: title
184+
185+
.. attention::
186+
The above tables filtering must be updated according to your Feature.
187+
188+
- Modify ``feature_name`` to be your Feature Name in lower snake case

process/folder_templates/modules/module_name/component_name/docs/requirements/chklst_req_inspection.rst

Lines changed: 40 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,16 +24,26 @@
2424
The above directive must be updated according to your Component.
2525

2626
- Modify ``Your Component Name`` to be your Component Name
27-
- Modify ``id`` to be your Component Name in upper snake case preceded by ``doc__`` and followed by ``_req_inspection``
27+
- Modify ``id`` to be your Component Name in lower snake case preceded by ``doc__`` and followed by ``_req_inspection``
2828
- Adjust ``status`` to be ``valid``
2929
- Adjust ``safety`` and ``tags`` according to your needs
3030

31-
[Your Component Name] Requirement Inspection Checklist
32-
======================================================
31+
Requirement Inspection Checklist
32+
================================
3333

3434
**Purpose**
35+
3536
The purpose of this requirement inspection checklist is to collect the topics to be checked during requirements inspection.
3637

38+
**Conduct**
39+
40+
As described in the concept :need:`doc_concept__wp_inspections` the following "inspection roles" are expected to be filled:
41+
42+
- author: these are the persons who did the last commits on the requirements in scope (can be derived from version mgt tool)
43+
- reviewer: these are all persons committing into this inspection document or giving a pull request verdict on it (can be derived from version mgt tool)
44+
- moderator: only needed for conflict resolution between author and reviewers, is the safety manager, security manager or quality manager called in as a reviewer (can be derived from version mgt tool)
45+
- test expert: <one of the reviewers explicitly named here, to cover REQ_08_01 as described>
46+
3747
**Checklist**
3848

3949
.. list-table:: Component Requirement Inspection Checklist
@@ -47,7 +57,7 @@
4757
- Remarks
4858
- Issue link
4959
* - REQ_01_01
50-
- Is the requirement sentence template used?
60+
- Is the requirement formulation template used?
5161
- see :need:`gd_temp__req_formulation`, this includes the use of "shall".
5262
-
5363
-
@@ -84,7 +94,7 @@
8494
-
8595
* - REQ_03_01
8696
- For stakeholder requirements: Is the *rationale* correct?
87-
- Rationales explain why the top level requirements were invented. Do those cover the requirement?
97+
- Rationales explain why the top level requirements were created. Do those cover the requirement?
8898
-
8999
-
90100
-
@@ -101,19 +111,19 @@
101111
-
102112
-
103113
* - REQ_05_01
104-
- Do the software requirements consider *timing constraints of the parent requirement*?
105-
- This bullet point encourages to think about timing constraints even if those are not explicitly mentioned in the parent requirement. If the reviewer of a requirement already knows or suspects that the implementation will be time consuming, one should think of the expectation of a "user".
114+
- Do the software requirements consider *timing constraints*?
115+
- This bullet point encourages to think about timing constraints even if those are not explicitly mentioned in the parent requirement. If the reviewer of a requirement already knows or suspects that the code execution will be consuming a lot of time, one should think of the expectation of a "user".
106116
-
107117
-
108118
-
109119
* - REQ_06_01
110-
- Does the Requirement consider *external interfaces*?
120+
- Does the requirement consider *external interfaces*?
111121
- The SW platform's external interfaces (to the user) are defined in the Feature Architecture, so the Feature and Component Requirements should determine the data consumed and set on these interfaces. Are output values completely defined?
112122
-
113123
-
114124
-
115125
* - REQ_07_01
116-
- Is the *ASIL Attribute* set correctly?
126+
- Is the *ASIL attribute* set correctly?
117127
- Derived requirements are checked automatically, see :need:`gd_req__req_linkage_safety`. But for the top level requirements this needs to be checked for correctness. Also AoU from external components need check for correct ASIL as those are the "origin" of safety requirements towards the SW platform.
118128
-
119129
-
@@ -126,7 +136,7 @@
126136
-
127137
* - REQ_08_01
128138
- Is the requirement *verifiable*?
129-
- Expectation is that at the time of the inspection already tests are created for the requirement. This can be checked via traces, but also :need:`gd_req__req_attr_test_covered` shows this. In case the requirement is not mature enough at the time of inspection (i.e. missing test cases), a test expert should be invited to the Pull-Request review to explicitly check this item.
139+
- If at the time of the inspection already tests are created for the requirement, the answer is yes. This can be checked via traces, but also :need:`gd_req__req_attr_test_covered` shows this. In case the requirement is not sufficiently traced to test cases already, a test expert is invited to the inspection to give his opinion whether the requirement is formulated in a way that supports test development and the available test infrastructure is sufficient to perform the test.
130140
-
131141
-
132142
-
@@ -148,13 +158,31 @@
148158
The above checklist entries must be filled according to your component requirements in scope.
149159
Also the need links mentioned in the checklist must be renamed to PROCESS_<old id> to point to the process documentation.
150160

151-
The following (valid) requirements are in the scope of this inspection:
161+
Note: If a Review ID is not applicable for your requirement, then state ""n/a" in status and comment accordingly in remarks. For example "no stakeholder requirement (no rationale needed)"
162+
163+
The following requirements with "inspected" tag set are in the scope of this inspection:
152164

153165
.. needtable::
154-
:filter: "component_name" in docname and "requirements" in docname and docname is not None
166+
:filter: "component_name" in docname and "requirements" in docname and docname is not None and status == "valid"
155167
:style: table
156168
:types: comp_req
157169
:tags: component_name
158170
:columns: id;status;tags
159171
:colwidths: 25,25,25
160172
:sort: title
173+
174+
And also the following AoUs with "inspected" tag set:
175+
176+
.. needtable::
177+
:filter: "component_name" in docname and "requirements" in docname and docname is not None and status == "valid"
178+
:style: table
179+
:types: aou_req
180+
:tags: component_name
181+
:columns: id;status;tags
182+
:colwidths: 25,25,25
183+
:sort: title
184+
185+
.. attention::
186+
The above tables filtering must be updated according to your Component.
187+
188+
- Modify ``component_name`` to be your Component Name in lower snake case

process/process_areas/requirements_engineering/guidance/requirements_inspection_checklist.rst

Lines changed: 7 additions & 109 deletions
Original file line numberDiff line numberDiff line change
@@ -17,121 +17,19 @@
1717
Requirement Inspection Checklist
1818
================================
1919

20+
21+
2022
.. gd_chklst:: Requirements Inspection Checklist Template
2123
:id: gd_chklst__req_inspection
2224
:status: valid
2325
:complies: std_req__iso26262__system_6412, std_req__iso26262__system_6414, std_req__iso26262__system_6421, std_req__iso26262__system_6422
2426
:tags: requirements_engineering
2527

26-
**Purpose**
27-
The purpose of this requirement inspection template is to collect the topics to be checked during requirements inspection.
28-
It will be filled out within the "inspection" pull request review of every requirement type.
28+
For the content see here:
2929

30-
**Checklist**
30+
- :need:`doc__component_name_req_inspection`
31+
- :need:`doc__feature_name_req_inspection`
3132

32-
.. list-table:: Requirement Inspection Checklist
33-
:header-rows: 1
34-
:widths: 10,30,50,6,6,8
33+
These have the same questions, but different scope and document naming.
3534

36-
* - Review ID
37-
- Acceptance Criteria
38-
- Guidance
39-
- Passed
40-
- Remarks
41-
- Issue link
42-
* - REQ_01_01
43-
- Is the requirement sentence template used?
44-
- see :need:`gd_temp__req_formulation`, this includes the use of "shall".
45-
-
46-
-
47-
-
48-
* - REQ_02_01
49-
- Is the requirement description *comprehensible* ?
50-
- If you think the requirement is hard to understand, comment here.
51-
-
52-
-
53-
-
54-
* - REQ_02_02
55-
- Is the requirement description *unambiguous* ?
56-
- Especially search for "weak words" like "about", "etc.", "relevant" and others (see the internet documentation on this). This check shall be supported by tooling.
57-
-
58-
-
59-
-
60-
* - REQ_02_03
61-
- Is the requirement description *atomic* ?
62-
- A good way to think about this is to consider if the requirement may be tested by one (positive) test case or needs more of these. The sentence template should also avoid being non-atomic already. Note that there are cases where also non-atomic requirements are the better ones, for example if those are better understandable.
63-
-
64-
-
65-
-
66-
* - REQ_02_04
67-
- Is the requirement description *feasible* ?
68-
- Expectation is that at the time of the inspection the requirement has already some implementation. This can be checked via traces, but also :need:`gd_req__req_attr_impl` shows this. In case the requirement is not mature enough at the time of inspection (i.e. not implemented at least as "proof-of-concept"), a development expert should be invited to the Pull-Request review to explicitly check this item.
69-
-
70-
-
71-
-
72-
* - REQ_02_05
73-
- Is the requirement description *independent from implementation* ?
74-
- This checkpoint should improve requirements definition in the sense that the "what" is described and not the "how" - the latter should be described in architecture/design derived from the requirement. But there can also be a good reason for this, for example we would require using a file format like JSON and even specify the formatting standard already on stakeholder requirement level because we want to be compatible. A finding in this checkpoint does not mean there is a safety problem in the requirement.
75-
-
76-
-
77-
-
78-
* - REQ_03_01
79-
- For stakeholder requirements: Is the *rationale* correct?
80-
- Rationales explain why the top level requirements were invented. Do those cover the requirement?
81-
-
82-
-
83-
-
84-
* - REQ_03_02
85-
- For other requirements: Is the *linkage to the parent requirement* correct?
86-
- Linkage to correct levels and ASIL attributes is checked automatically, but it needs checking if the child requirement implements (at least) a part of the parent requirement.
87-
-
88-
-
89-
-
90-
* - REQ_04_01
91-
- Is the requirement *internally and externally consistent*?
92-
- Does the requirement contradict other requirements within the same or higher levels? One may restrict the search to the feature for component requirements, for features to other features using same components.
93-
-
94-
-
95-
-
96-
* - REQ_05_01
97-
- Do the software requirements consider *timing constraints of the parent requirement*?
98-
- This bullet point encourages to think about timing constraints even if those are not explicitly mentioned in the parent requirement. If the reviewer of a requirement already knows or suspects that the implementation will be time consuming, one should think of the expectation of a "user".
99-
-
100-
-
101-
-
102-
* - REQ_06_01
103-
- Does the Requirement consider *external interfaces*?
104-
- The SW platform's external interfaces (to the user) are defined in the Feature Architecture, so the Feature and Component Requirements should determine the data consumed and set on these interfaces. Are output values completely defined?
105-
-
106-
-
107-
-
108-
* - REQ_07_01
109-
- Is the *ASIL Attribute* set correctly?
110-
- Derived requirements are checked automatically, see :need:`gd_req__req_linkage_safety`. But for the top level requirements this needs to be checked for correctness. Also AoU from external components need check for correct ASIL as those are the "origin" of safety requirements towards the SW platform.
111-
-
112-
-
113-
-
114-
* - REQ_07_02
115-
- Is the attribute *security* set correctly?
116-
- Stakeholder requirements security attribute should be set based on Threat Analysis and Risk Assessment (TARA) (process is TBD). Checklist item is supported by automated check: "Every requirement which satisfies a requirement with security attribute set to YES inherits this". Expectation is that the feature/component requirements/architecture may also be subject to a Software Security Criticality Analysis (process is TBD).
117-
-
118-
-
119-
-
120-
* - REQ_08_01
121-
- Is the requirement *verifiable*?
122-
- Expectation is that at the time of the inspection already tests are created for the requirement. This can be checked via traces, but also :need:`gd_req__req_attr_test_covered` shows this. In case the requirement is not mature enough at the time of inspection (i.e. missing test cases), a test expert should be invited to the Pull-Request review to explicitly check this item.
123-
-
124-
-
125-
-
126-
* - REQ_09_01
127-
- For stakeholder requirements: Do those cover assumed safety mechanisms needed by the hardware and system?
128-
- Note that the feature/component requirements also cover safety mechanisms in case those are needed to mitigate failures found during :ref:`safety_analysis`
129-
-
130-
-
131-
-
132-
* - REQ_09_02
133-
- For other requirements: Do the requirements defining a safety mechanism contain the error reaction leading to a safe state?
134-
- Alternatively to the safe state there could also be "repair" mechanisms. Also do not forget to consider REQ_05_01 for these.
135-
-
136-
-
137-
-
35+
If stakeholder requirements inspection is required use one of the above templates and modify scope/naming accordingly.

0 commit comments

Comments
 (0)