Skip to content

Commit 9aa792c

Browse files
MichalKoziorowski-TomTomvietj
authored andcommitted
Fixed NPE in updateEndpoints when endpoints update even does not contain addresses array
1 parent 888e404 commit 9aa792c

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

src/main/java/io/vertx/serviceresolver/kube/impl/KubeServiceState.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,14 @@ void updateEndpoints(JsonObject item) {
6464
JsonObject subset = subsets.getJsonObject(j);
6565
JsonArray addresses = subset.getJsonArray("addresses");
6666
JsonArray ports = subset.getJsonArray("ports");
67-
for (int k = 0;k < addresses.size();k++) {
68-
JsonObject address = addresses.getJsonObject(k);
69-
String ip = address.getString("ip");
70-
podIps.add(ip);
67+
// Addresses array can be null when service pods are getting ready slowly
68+
// and are first added to notReadyAddresses array.
69+
if (addresses != null) {
70+
for (int k = 0;k < addresses.size();k++) {
71+
JsonObject address = addresses.getJsonObject(k);
72+
String ip = address.getString("ip");
73+
podIps.add(ip);
74+
}
7175
}
7276
for (int k = 0;k < ports.size();k++) {
7377
JsonObject port = ports.getJsonObject(k);

0 commit comments

Comments
 (0)