Used the most strict psalm level and fixed all psalm errors (#377)

Author: aivchen

.gitattributes

@@ -3,5 +3,4 @@
 /.* export-ignore
 /phpunit.xml.dist export-ignore
 /psalm.xml export-ignore
-/psalm.baseline.xml export-ignore
 /README.md export-ignore

psalm.baseline.xml

@@ -3,21 +3,16 @@
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xmlns="https://getpsalm.org/schema/config"
     xsi:schemaLocation="https://getpsalm.org/schema/config ./vendor/vimeo/psalm/config.xsd"
-    errorBaseline="psalm.baseline.xml"
+    errorLevel="1"
+    findUnusedCode="false"
+    findUnusedPsalmSuppress="true"
+    disableSuppressAll="true"
+    findUnusedVariablesAndParams="true"
 >
     <projectFiles>
         <directory name="src" />
         <ignoreFiles>
             <directory name="vendor" />
         </ignoreFiles>
     </projectFiles>
-
-    <issueHandlers>
-        <DeprecatedMethod>
-            <errorLevel type="suppress">
-                <!-- This issue needs to be resolved before upgrading to Lexer 3 -->
-                <referencedMethod name="Doctrine\Common\Lexer\Token::offsetGet"/>
-            </errorLevel>
-        </DeprecatedMethod>
-    </issueHandlers>
 </psalm>

psalm.xml

@@ -61,7 +61,7 @@ class EmailLexer extends AbstractLexer
     /**
      * US-ASCII visible characters not valid for atext (@link http://tools.ietf.org/html/rfc5322#section-3.2.3)
      *
-     * @var array
+     * @var array<string, int>
      */
     protected $charValue = [
         '{'    => self::S_OPENCURLYBRACES,
@@ -177,7 +177,6 @@ public function reset(): void
      * @throws \UnexpectedValueException
      * @return boolean
      *
-     * @psalm-suppress InvalidScalarArgument
      */
     public function find($type): bool
     {

src/EmailLexer.php

@@ -8,11 +8,12 @@
 use Egulias\EmailValidator\Warning\CFWSNearAt;
 use Egulias\EmailValidator\Result\InvalidEmail;
 use Egulias\EmailValidator\Result\Reason\ExpectingATEXT;
+use Egulias\EmailValidator\Warning\Warning;
 
 class LocalComment implements CommentStrategy
 {
     /**
-     * @var array
+     * @var array<int, Warning>
      */
     private $warnings = [];
 

src/Parser/CommentStrategy/LocalComment.php

@@ -307,6 +307,7 @@ private function isLabelTooLong(string $label): bool
     {
         if (preg_match('/[^\x00-\x7F]/', $label)) {
             idn_to_ascii($label, IDNA_DEFAULT, INTL_IDNA_VARIANT_UTS46, $idnaInfo);
+            /** @psalm-var array{errors: int, ...} $idnaInfo */
             return (bool) ($idnaInfo['errors'] & IDNA_ERROR_LABEL_TOO_LONG);
         }
         return strlen($label) > self::LABEL_MAX_LENGTH;

src/Parser/DomainPart.php

@@ -7,13 +7,12 @@ class DNSGetRecordWrapper
     /**
      * @param string $host
      * @param int $type
-     * 
+     *
      * @return DNSRecords
      */
     public function getRecords(string $host, int $type): DNSRecords
     {
         // A workaround to fix https://bugs.php.net/bug.php?id=73149
-        /** @psalm-suppress InvalidArgument */
         set_error_handler(
             static function (int $errorLevel, string $errorMessage): never {
                 throw new \RuntimeException("Unable to get DNS record for the host: $errorMessage");

src/Validation/DNSGetRecordWrapper.php

@@ -5,15 +5,15 @@
 class DNSRecords
 {
     /**
-     * @param array $records
+     * @param list<array<array-key, mixed>> $records
      * @param bool $error
      */
     public function __construct(private readonly array $records, private readonly bool $error = false)
     {
     }
 
     /**
-     * @return array
+     * @return list<array<array-key, mixed>>
      */
     public function getRecords(): array
     {

src/Validation/DNSRecords.php

@@ -22,9 +22,6 @@ public function __construct()
         }
     }
 
-    /**
-     * @psalm-suppress InvalidArgument
-     */
     public function isValid(string $email, EmailLexer $emailLexer) : bool
     {
         $checker = new Spoofchecker();