contrib/flask: raise an exception if logging parameter is passed to ElasticAPM

Author: xrmx

elasticapm/contrib/flask/__init__.py

@@ -82,6 +82,10 @@ def __init__(self, app=None, client=None, client_cls=Client, **defaults) -> None
         self.client = client or get_client()
         self.client_cls = client_cls
 
+        logging = defaults.pop("logging", None)
+        if logging is not None:
+            raise ValueError("Flask log shipping has been removed, drop the ElasticAPM logging parameter")
+
         if app:
             self.init_app(app, **defaults)
 

tests/contrib/flask/flask_tests.py

@@ -50,6 +50,11 @@
 pytestmark = pytest.mark.flask
 
 
+def test_logging_parameter_raises_exception():
+    with pytest.raises(ValueError, match="Flask log shipping has been removed"):
+        ElasticAPM(config=None, logging=True)
+
+
 def test_error_handler(flask_apm_client):
     client = flask_apm_client.app.test_client()
     response = client.get("/an-error/")