use await memoized exists

Author: mmaietta

packages/app-builder-lib/src/node-module-collector/nodeModulesCollector.ts

@@ -172,6 +172,20 @@ export abstract class NodeModulesCollector<ProdDepType extends Dependency<ProdDe
     return this.cache.realPath.get(filePath)!
   }
 
+  protected requireMemoized(pkgPath: string): PackageJson {
+    if (!this.cache.packageJson.has(pkgPath)) {
+      this.cache.packageJson.set(pkgPath, require(pkgPath))
+    }
+    return this.cache.packageJson.get(pkgPath)!
+  }
+
+  protected existsSyncMemoized(filePath: string): boolean {
+    if (!this.cache.exists.has(filePath)) {
+      this.cache.exists.set(filePath, fs.existsSync(filePath))
+    }
+    return this.cache.exists.get(filePath)!
+  }
+
   protected async resolvePath(filePath: string): Promise<string> {
     // Check if we've already resolved this path
     if (this.cache.realPath.has(filePath)) {
@@ -254,20 +268,6 @@ export abstract class NodeModulesCollector<ProdDepType extends Dependency<ProdDe
     return null
   }
 
-  protected requireMemoized(pkgPath: string): PackageJson {
-    if (!this.cache.packageJson.has(pkgPath)) {
-      this.cache.packageJson.set(pkgPath, require(pkgPath))
-    }
-    return this.cache.packageJson.get(pkgPath)!
-  }
-
-  protected existsSyncMemoized(filePath: string): boolean {
-    if (!this.cache.exists.has(filePath)) {
-      this.cache.exists.set(filePath, fs.existsSync(filePath))
-    }
-    return this.cache.exists.get(filePath)!
-  }
-
   protected cacheKey(pkg: ProdDepType): string {
     const rel = path.relative(this.rootDir, pkg.path)
     return `${pkg.name}::${pkg.version}::${rel ?? "."}`

packages/app-builder-lib/src/node-module-collector/pnpmNodeModulesCollector.ts

@@ -20,7 +20,7 @@ export class PnpmNodeModulesCollector extends NodeModulesCollector<PnpmDependenc
       const packageName = depTree.name || depTree.from
       if (packageName) {
         const hoistedPath = path.join(this.rootDir, "node_modules", packageName)
-        if (this.existsSyncMemoized(hoistedPath)) {
+        if (await this.existsMemoized(hoistedPath)) {
           return hoistedPath
         }
       }
@@ -74,7 +74,7 @@ export class PnpmNodeModulesCollector extends NodeModulesCollector<PnpmDependenc
       // Then check if optional dependency path exists (using actual resolved path)
       if (json?.optionalDependencies?.[packageName]) {
         const actualPath = await this.resolveActualPath(dependency)
-        if (!this.existsSyncMemoized(actualPath)) {
+        if (!(await this.existsMemoized(actualPath))) {
           log.debug(null, `Optional dependency ${packageName}@${dependency.version} path doesn't exist: ${actualPath}`)
           return undefined
         }