eslint issues

Author: mmaietta

packages/app-builder-lib/src/codeSign/macCodeSign.ts

@@ -212,7 +212,7 @@ async function importCerts(keychainFile: string, paths: Array<string>, keyPasswo
   }
 }
 
-export async function sign(opts: SignOptions): Promise<void> {
+export function sign(opts: SignOptions): Promise<void> {
   return retry(() => signAsync(opts), 3, 5000, 5000)
 }
 

packages/app-builder-lib/src/electron/electronVersion.ts

@@ -75,21 +75,21 @@ export async function computeElectronVersion(projectDir: string): Promise<string
         accept: "application/xml, application/atom+xml, text/xml, */*",
       },
     })
-    const feed = parseXml(feedXml!)
+    const feed = parseXml(feedXml)
     const latestRelease = feed.element("entry", false, `No published versions on GitHub`)
     const v = /\/tag\/v?([^/]+)$/.exec(latestRelease.element("link").attribute("href"))![1]
     return v.startsWith("v") ? v.substring(1) : v
   } else if (dependency?.version === "latest") {
     log.warn('Electron version is set to "latest", but it is recommended to set it to some more restricted version range.')
     try {
       const releaseInfo = JSON.parse(
-        (await httpExecutor.request({
+        await httpExecutor.request({
           hostname: "github.com",
           path: `/electron/${dependency.name === "electron-nightly" ? "nightlies" : "electron"}/releases/latest`,
           headers: {
             accept: "application/json",
           },
-        }))!
+        })
       )
       const version = releaseInfo.tag_name.startsWith("v") ? releaseInfo.tag_name.substring(1) : releaseInfo.tag_name
       log.info({ version }, `resolve ${dependency.name}@${dependency.version}`)

packages/app-builder-lib/src/targets/differentialUpdateInfoBuilder.ts

@@ -27,7 +27,7 @@ export function createNsisWebDifferentialUpdateInfo(artifactPath: string, packag
       path: file,
       // https://github.com/electron-userland/electron-builder/issues/2583
       file,
-    } as any
+    }
   }
   return { packages }
 }

packages/app-builder-lib/src/targets/pkg.ts

@@ -80,7 +80,7 @@ export class PkgTarget extends Target {
       args.push("--package-path", extraPackages.packagePath)
     }
     args.push(artifactPath)
-    use(options.productbuild, it => args.push(...(it as any)))
+    use(options.productbuild, it => args.push(...it))
     await exec("productbuild", args, {
       cwd: appOutDir,
     })

packages/dmg-builder/src/dmg.ts

@@ -262,7 +262,9 @@ async function customizeDmg(volumePath: string, specification: DmgOptions, packa
 
   const args = ["dmg", "--volume", volumePath]
   if (specification.icon != null) {
-    args.push("--icon", (await packager.getResource(specification.icon))!)
+    const icon = await packager.getResource(specification.icon)
+    // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
+    args.push("--icon", icon!)
   }
   if (backgroundFile != null) {
     args.push("--background", backgroundFile)

packages/dmg-builder/src/dmgUtil.ts

@@ -33,7 +33,7 @@ export async function attachAndExecute(dmgPath: string, readWrite: boolean, task
   return await executeFinally(task(), () => detach(device))
 }
 
-export async function detach(name: string) {
+export function detach(name: string) {
   return hdiUtil(["detach", "-quiet", name])
 }
 

packages/dmg-builder/src/hdiuil.ts

@@ -1,6 +1,6 @@
 import { exec, log, retry } from "builder-util"
 
-export async function hdiUtil(args: string[]) {
+export function hdiUtil(args: string[]) {
   return retry(
     () => exec("hdiutil", args),
     5,

packages/electron-builder/src/cli/install-app-deps.ts

@@ -74,5 +74,5 @@ function main() {
 
 if (require.main === module) {
   log.warn("please use as subcommand: electron-builder install-app-deps")
-  main().catch(printErrorAndExit)
+  void main().catch(printErrorAndExit)
 }

packages/electron-builder/src/publish.ts

@@ -117,5 +117,5 @@ function main() {
 
 if (require.main === module) {
   log.warn("please use as subcommand: electron-builder publish")
-  main().catch(printErrorAndExit)
+  void main().catch(printErrorAndExit)
 }

packages/electron-publish/src/keygenPublisher.ts

@@ -148,7 +148,7 @@ export class KeygenPublisher extends HttpPublisher {
     await httpExecutor.doApiRequest(configureRequestOptions(upload, null, "PUT"), this.context.cancellationToken, requestProcessor)
   }
 
-  private async createArtifact(releaseId: any, fileName: string, dataLength: number): Promise<{ data?: KeygenArtifact; errors?: KeygenError[] }> {
+  private createArtifact(releaseId: any, fileName: string, dataLength: number): Promise<{ data?: KeygenArtifact; errors?: KeygenError[] }> {
     const upload: RequestOptions = {
       hostname: this.hostname,
       path: `${this.basePath}/artifacts`,
@@ -208,7 +208,7 @@ export class KeygenPublisher extends HttpPublisher {
     }
   }
 
-  private async getRelease(): Promise<{ data?: KeygenRelease; errors?: KeygenError[] }> {
+  private getRelease(): Promise<{ data?: KeygenRelease; errors?: KeygenError[] }> {
     const req: RequestOptions = {
       hostname: this.hostname,
       path: `${this.basePath}/releases/${this.version}?product=${this.info.product}`,
@@ -222,7 +222,7 @@ export class KeygenPublisher extends HttpPublisher {
     return parseJson(httpExecutor.request(configureRequestOptions(req, this.auth, "GET"), this.context.cancellationToken, null))
   }
 
-  private async createRelease(): Promise<{ data?: KeygenRelease; errors?: KeygenError[] }> {
+  private createRelease(): Promise<{ data?: KeygenRelease; errors?: KeygenError[] }> {
     const req: RequestOptions = {
       hostname: this.hostname,
       path: `${this.basePath}/releases`,