Skip to content

Commit aaae649

Browse files
committed
fix mac dist name
1 parent 5161258 commit aaae649

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

.changeset/poor-bats-clap.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
2-
"app-builder-lib": patch
3-
"builder-util": patch
2+
"app-builder-lib": minor
3+
"builder-util": minor
44
---
55

66
feat: migrate `electronDownload` to use `electron/get` official package. provides much better support for mirrors

packages/app-builder-lib/src/electron/ElectronFramework.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ export async function createElectronFrameworkSupport(configuration: Configuratio
5151
}
5252

5353
const branding = createBrandingOpts(configuration)
54-
return new ElectronFramework(branding.projectName, version, branding.productName)
54+
return new ElectronFramework(branding.projectName, version, `${branding.productName}.app`)
5555
}
5656

5757
class ElectronFramework implements Framework {

packages/app-builder-lib/src/platformPackager.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -198,11 +198,8 @@ export abstract class PlatformPackager<DC extends PlatformSpecificBuildOptions>
198198
}
199199

200200
private getExtraFileMatchers(isResources: boolean, appOutDir: string, options: GetFileMatchersOptions): Array<FileMatcher> | null {
201-
const base = isResources
202-
? this.getResourcesDir(appOutDir)
203-
: this.platform === Platform.MAC
204-
? path.join(appOutDir, `${this.appInfo.productFilename}.app`, "Contents")
205-
: appOutDir
201+
const outDir = this.platform === Platform.MAC ? path.join(appOutDir, this.info.framework.distMacOsAppName, "Contents") : appOutDir
202+
const base = isResources ? this.getResourcesDir(appOutDir) : outDir
206203
return getFileMatchers(this.config, isResources ? "extraResources" : "extraFiles", base, options)
207204
}
208205

0 commit comments

Comments
 (0)