builds broken since v26.3.0

[t3chguy]

Error originally seen element-hq/element-desktop#2710 (comment)

Uncaught Exception:
Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/private/var/folders/gm/y_c_9xc962g1ryjdx78d8hfm0000gn/T/AppTranslocation/4A618F1C-95A8-45EC-AD6F-5BA68B40D0A5/d/Element Nightly.app/Contents/Resources/app.asar/node_modules/ajv/dist/2020.js' imported from /private/var/folders/gm/y_c_9xc962g1ryjdx78d8hfm0000gn/T/AppTranslocation/4A618F1C-95A8-45EC-AD6F-5BA68B40D0A5/d/Element Nightly.app/Contents/Resources/app.asar/node_modules/conf/dist/source/index.js
at finalizeResolution (node:internal/modules/esm/resolve:278:11)
at moduleResolve (node:internal/modules/esm/resolve:871:10)
at defaultResolve (node:internal/modules/esm/resolve:995:11)
at #cachedDefaultResolve (node:internal/modules/esm/loader:731:20)
at ModuleLoader.resolve (node:internal/modules/esm/loader:708:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:310:38)
at ModuleJob._link (node:internal/modules/esm/module_job:182:49)

Seeing as 26.3.0 tweaked how yarn classic module resolution works in #9309 I thought I would try to upgrade to yarn berry via corepack and got a different error which looks similar to #8842

Uncaught Exception:
Error: Cannot find module 'ms'
Require stack:
- /private/var/folders/gm/y_c_9xc962g1ryjdx78d8hfm0000gn/T/AppTranslocation/52E1BEAF-AED1-4213-A5E2-C0BBBF28C0BD/d/Element Nightly.app/Contents/Resources/app.asar/node_modules/debug/src/common.js
- /private/var/folders/gm/y_c_9xc962g1ryjdx78d8hfm0000gn/T/AppTranslocation/52E1BEAF-AED1-4213-A5E2-C0BBBF28C0BD/d/Element Nightly.app/Contents/Resources/app.asar/node_modules/debug/src/node.js
- /private/var/folders/gm/y_c_9xc962g1ryjdx78d8hfm0000gn/T/AppTranslocation/52E1BEAF-AED1-4213-A5E2-C0BBBF28C0BD/d/Element Nightly.app/Contents/Resources/app.asar/node_modules/debug/src/index.js
- /private/var/folders/gm/y_c_9xc962g1ryjdx78d8hfm0000gn/T/AppTranslocation/52E1BEAF-AED1-4213-A5E2-C0BBBF28C0BD/d/Element Nightly.app/Contents/Resources/app.asar/node_modules/require-in-the-middle/index.js
- /private/var/folders/gm/y_c_9xc962g1ryjdx78d8hfm0000gn/T/AppTranslocation/52E1BEAF-AED1-4213-A5E2-C0BBBF28C0BD/d/Element Nightly.app/Contents/Resources/app.asar/node_modules/@opentelemetry/instrumentation/build/src/platform/node/RequireInTheMiddleSingleton.js
- /private/var/folders/gm/y_c_9xc962g1ryjdx78d8hfm0000gn/T/AppTranslocation/52E1BEAF-AED1-4213-A5E2-C0BBBF28C0BD/d/Element Nightly.app/Contents/Resources/app.asar/node_modules/@opentelemetry/instrumentation/build/src/platform/node/instrumentation.js
- /private/var/folders/gm/y_c_9xc962g1ryjdx78d8hfm0000gn/T/AppTranslocation/52E1BEAF-AED1-4213-A5E2-C0BBBF28C0BD/d/Element Nightly.app/Contents/Resources/app.asar/node_modules/@opentelemetry/instrumentation/build/src/platform/node/index.js
- /private/var/folders/gm/y_c_9xc962g1ryjdx78d8hfm0000gn/T/AppTranslocation/52E1BEAF-AED1-4213-A5E2-C0BBBF28C0BD/d/Element Nightly.app/Contents/Resources/app.asar/node_modules/@opentelemetry/instrumentation/build/src/platform/index.js
- /private/var/folders/gm/y_c_9xc962g1ryjdx78d8hfm0000gn/T/AppTranslocation/52E1BEAF-AED1-4213-A5E2-C0BBBF28C0BD/d/Element Nightly.app/Contents/Resources/app.asar/node_modules/@opentelemetry/instrumentation/build/src/index.js
at Module._resolveFilename (node:internal/modules/cjs/loader:1390:15)
at s._resolveFilename (node:electron/js2c/browser_init:2:130470)
at defaultResolveImpl (node:internal/modules/cjs/loader:1032:19)
at resolveForCJSWithHooks (node:internal/modules/cjs/loader:1037:22)
at Module._load (node:internal/modules/cjs/loader:1199:37)
at c._load (node:electron/js2c/node_init:2:17993)
at TracingChannel.traceSync (node:diagnostics_channel:328:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:244:24)
at Module.require (node:internal/modules/cjs/loader:1470:12)
at require (node:internal/modules/helpers:147:16)

Tested in element-hq/element-desktop#2721

[mmaietta]

Can you try .2? I piped in a fix into 26.3.1/2 and have another node collector fix going into 23.6.3 - waiting on CI builds to finish on it.
The tweaks in the module collectors were made to support corepack to properly add unit tests for different package managers using common test fixtures

[beyondkmp]

electron-buidler: 26.3.2
yarn4
app: https://github.com/CherryHQ/cherry-studio

[t3chguy]

26.3.2 doesn't fix it for element-desktop either with yarn cherry

https://github.com/element-hq/element-desktop/actions/runs/19759178068/job/56617450761?pr=2721

[t3chguy]

Different error with yarn classic

[mmaietta]

Thanks for the repro's folks and links to repos. Investigating this asap.

[mmaietta]

@t3chguy I'm confused with your project setup in terms of the yarn classic screenshot. The path that it's pointing to (for that import) is being hoisted to the root node_modules dir (per the path in your screenshot). When I navigate to that path post yarn install (classic), the file is not present from being installed at all.

Rather, instead, the file does exist, but at:

~/D/element-desktop> find . -iname "2020.js" 
./node_modules/es-abstract/operations/2020.js
./node_modules/conf/node_modules/ajv/dist/2020.js

Any thoughts on how that could happen?

Screenshots for additional reference. I'll continue debugging the other cases reported

[mmaietta]

Update:

Got a fix working for yarn cherry so that the app launches for Element Desktop

Working on Cherry Studio now

[mmaietta]

@beyondkmp @t3chguy please TAL at #9401

[t3chguy]

@mmaietta thanks - can test as soon as you ship 26.3.3

[mmaietta]

Kicking off publish now

[beyondkmp]

26.3.3 didn't fix the problem with cherry studio, the same error is still reported.