From 2d9f9bb3a25aa16d2aeac13ed5ee7d02a2583845 Mon Sep 17 00:00:00 2001
From: beyondkmp <beyondkmp@gmail.com>
Date: Fri, 12 Sep 2025 17:21:56 +0800
Subject: [PATCH 1/3] fix: Enhance dependency path validation in
 NodeModulesCollector

Added a check to ensure the existence of dependency paths before processing them, addressing issues related to missing paths in npm list. This change improves the robustness of the dependency collection logic.
---
 .../src/node-module-collector/nodeModulesCollector.ts  | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/packages/app-builder-lib/src/node-module-collector/nodeModulesCollector.ts b/packages/app-builder-lib/src/node-module-collector/nodeModulesCollector.ts
index 19e98322a83..10a6cc7ccef 100644
--- a/packages/app-builder-lib/src/node-module-collector/nodeModulesCollector.ts
+++ b/packages/app-builder-lib/src/node-module-collector/nodeModulesCollector.ts
@@ -140,10 +140,18 @@ export abstract class NodeModulesCollector<T extends Dependency<T, OptionalsType
     for (const d of dependencies.values()) {
       const reference = [...d.references][0]
       const p = this.allDependencies.get(`${d.name}@${reference}`)?.path
-      if (p === undefined) {
+      if (p === undefined ) {
         log.debug({ name: d.name, reference }, "cannot find path for dependency")
         continue
       }
+
+      // fix npm list issue
+      // https://github.com/npm/cli/issues/8535
+      if(!fs.existsSync(p)) {
+        log.debug({ name: d.name, reference, p }, "dependency path does not exist")
+        continue
+      }
+
       const node: NodeModuleInfo = {
         name: d.name,
         version: reference,

From 349cd5e691d6056de929dc4a4c970f644b027c6b Mon Sep 17 00:00:00 2001
From: beyondkmp <beyondkmp@gmail.com>
Date: Fri, 12 Sep 2025 17:24:02 +0800
Subject: [PATCH 2/3] prettier

---
 .../src/node-module-collector/nodeModulesCollector.ts         | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/app-builder-lib/src/node-module-collector/nodeModulesCollector.ts b/packages/app-builder-lib/src/node-module-collector/nodeModulesCollector.ts
index 10a6cc7ccef..184b4edcd04 100644
--- a/packages/app-builder-lib/src/node-module-collector/nodeModulesCollector.ts
+++ b/packages/app-builder-lib/src/node-module-collector/nodeModulesCollector.ts
@@ -140,14 +140,14 @@ export abstract class NodeModulesCollector<T extends Dependency<T, OptionalsType
     for (const d of dependencies.values()) {
       const reference = [...d.references][0]
       const p = this.allDependencies.get(`${d.name}@${reference}`)?.path
-      if (p === undefined ) {
+      if (p === undefined) {
         log.debug({ name: d.name, reference }, "cannot find path for dependency")
         continue
       }
 
       // fix npm list issue
       // https://github.com/npm/cli/issues/8535
-      if(!fs.existsSync(p)) {
+      if (!fs.existsSync(p)) {
         log.debug({ name: d.name, reference, p }, "dependency path does not exist")
         continue
       }

From 07306502ef2bcf9960d7a8f0f9817d7ef53d66b5 Mon Sep 17 00:00:00 2001
From: beyondkmp <beyondkmp@gmail.com>
Date: Fri, 12 Sep 2025 17:35:11 +0800
Subject: [PATCH 3/3] add changeset

---
 .changeset/old-cherries-draw.md | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 .changeset/old-cherries-draw.md

diff --git a/.changeset/old-cherries-draw.md b/.changeset/old-cherries-draw.md
new file mode 100644
index 00000000000..de47ef35bc9
--- /dev/null
+++ b/.changeset/old-cherries-draw.md
@@ -0,0 +1,5 @@
+---
+"app-builder-lib": patch
+---
+
+Optional dep's path cannot find in newest npm