feat: Check for Silent Flag in NSIS Uninstaller #9282
+95
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2d95288 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
naderhen
changed the title
Collaborator
|
FYI, this LGTM, but I need to fix the core |
Contributor
Author
|
thanks @mmaietta ! Will keep an eye out for when this goes in |
mmaietta
reviewed
Oct 3, 2025
mmaietta
reviewed
Nov 11, 2025
mmaietta
approved these changes
Nov 11, 2025
Contributor
Author
|
@mmaietta apologies for the re-request, github said I needed a new approval after updating the branch against main |
mmaietta
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no way to suppress the "Are you sure you want to uninstall?" dialog when running the uninstaller exe with the
\S. It doesn't appear that there are any hooks that would allow me to check for this on my own, so I'm hoping this helps.