-
Notifications
You must be signed in to change notification settings - Fork 45
Open
Labels
bugSomething isn't workingSomething isn't working
Description
The initial implementation for this library (163f495) threw an error if the count of Mach-O files was different between .app bundles.
Line 150 in 163f495
| 'While trying to merge mach-o files across your apps we found a mismatch, the number of mach-o files is not the same between the arm64 and x64 builds', |
In (46ff9c4), the scope of this check was widened to account for any file that wasn't an app.asar archive or a .bin V8 snapshot.
Line 110 in 46ff9c4
| const dupedFiles = (files: AppFile[]) => files.filter(f => f.type !== AppFileType.SNAPSHOT && f.type !== AppFileType.APP_CODE); |
However, the initial error message has not changed, which can be misleading for users encountering it.
I'm not sure if we only care about Mach-O files here and should also filter out AppFileType.PLAIN files in this check, or if the error message should be clarified instead.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working