fix: auto-recover from OAuth app deletion after token revocation #3382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-zone#2422) When users revoke OAuth access on their Mastodon server, the OAuth application gets deleted but remains cached in Elk. This causes login failures with 'Client authentication failed due to unknown client'. This fix adds automatic detection and recovery: - Detects specific invalid_client errors (401 status) - Automatically invalidates stale cached OAuth credentials - Creates fresh OAuth application and retries seamlessly - Single retry prevents infinite loops - Preserves existing error handling for other failures Changes: - Add invalidateApp() function to server/utils/shared.ts - Enhanced error handling in server/api/[server]/oauth/[origin].ts - Backward compatible, zero breaking changes Fixes elk-zone#2422
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
danielroe
approved these changes
Sep 22, 2025
danielroe
changed the title
|
Hey @abcb1122 , you can claim the bounty added to the related issue #3382 here by sending your PR : https://gitpay.me/#/task/1063/revoked-access-to-elk-and-now-cannot-log-back-in |
|
@abcb1122 Thank you so much! Many people have been waiting for a fix for this issue 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users revoke OAuth access on their Mastodon server, the OAuth application gets deleted but remains cached in Elk. This causes login failures with 'Client authentication failed due to unknown client'.
This fix adds automatic detection and recovery:
Changes:
Fixes #2422