Skip to content

No error is reported if elm-review fails to load #628

@edkelly303

Description

@edkelly303

Expected Behavior

If the language server tries to run elm-review, but it fails (for example, because there's a mismatch between the elm-review npm package version and the Elm package version), an error message should be displayed to the user so that they know they need to fix their configuration.

Current Behavior

If the language server tries to run elm-review, but it fails, no error message is displayed. If the user doesn't realise that elm-review has silently failed to run, they may assume that the reason they're not seeing any feedback from elm-review is because it hasn't found any issues in their project.

Steps to Reproduce (for bugs)

Install versions of the elm-review npm package and Elm package that are not compatible, then start the language server. If you open the output tab in VS Code and look at the LS's output, you can see that elm-review has failed with an error about incompatible versions. But no error message is shown to the user.

Your Environment

  • Version used: 2.7.2
  • Editor name and version: VS Code 1.80.1
  • Environment name and version: NodeJS 16.13.0
  • Operating System and version: Ubuntu 20.04

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions