Skip to content

Commit 2609140

Browse files
committed
Add some flagging
1 parent 39458f6 commit 2609140

File tree

5 files changed

+50
-16
lines changed

5 files changed

+50
-16
lines changed

files/_js_babel.config.cjs

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,13 @@
1+
<% if (compat) { %>
12
const {
23
babelCompatSupport,
34
templateCompatSupport,
45
} = require('@embroider/compat/babel');
6+
<% } else { %>
7+
const { buildMacros } = require('@embroider/macros/babel');
8+
9+
const macros = buildMacros();
10+
<% } %>
511

612
module.exports = {
713
plugins: [
@@ -13,8 +19,9 @@ module.exports = {
1319
'ember-cli-htmlbars',
1420
'ember-cli-htmlbars-inline-precompile',
1521
'htmlbars-inline-precompile',
16-
],
17-
transforms: [...templateCompatSupport()],
22+
],<% if (compat) { %>
23+
transforms: [...templateCompatSupport()],<% } else { %>
24+
transforms: [...macros.templateMacros],<% } %>
1825
},
1926
],
2027
[
@@ -32,8 +39,9 @@ module.exports = {
3239
useESModules: true,
3340
regenerator: false,
3441
},
35-
],
36-
...babelCompatSupport(),
42+
],<% if (compat) { %>
43+
...babelCompatSupport(),<% } else { %>
44+
...macros.babelMacros,<% } %>
3745
],
3846

3947
generatorOpts: {

files/_ts_babel.config.cjs

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,13 @@
1+
<% if (compat) { %>
12
const {
23
babelCompatSupport,
34
templateCompatSupport,
45
} = require('@embroider/compat/babel');
6+
<% } else { %>
7+
const { buildMacros } = require('@embroider/macros/babel');
8+
9+
const macros = buildMacros();
10+
<% } %>
511

612
module.exports = {
713
plugins: [
@@ -21,8 +27,9 @@ module.exports = {
2127
'ember-cli-htmlbars',
2228
'ember-cli-htmlbars-inline-precompile',
2329
'htmlbars-inline-precompile',
24-
],
25-
transforms: [...templateCompatSupport()],
30+
],<% if (compat) { %>
31+
transforms: [...templateCompatSupport()],<% } else { %>
32+
transforms: [...macros.templateMacros],<% } %>
2633
},
2734
],
2835
[
@@ -40,8 +47,9 @@ module.exports = {
4047
useESModules: true,
4148
regenerator: false,
4249
},
43-
],
44-
...babelCompatSupport(),
50+
],<% if (compat) { %>
51+
...babelCompatSupport(),<% } else { %>
52+
...macros.babelMacros,<% } %>
4553
],
4654

4755
generatorOpts: {

files/package.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,10 @@
5353
"@ember/test-waiters": "^4.1.0",
5454
"@embroider/macros": "^1.18.0",
5555
"@embroider/core": "^4.1.0",
56-
"@embroider/vite": "^1.1.5",
57-
"@embroider/compat": "^4.1.0",
58-
"@embroider/router": "^3.0.1",
59-
"@embroider/config-meta-loader": "^1.0.0",
56+
"@embroider/vite": "^1.1.5",<% if (compat) { %>
57+
"@embroider/compat": "^4.1.0",<% } %>
58+
"@embroider/router": "^3.0.1",<% if (compat) { %>
59+
"@embroider/config-meta-loader": "^1.0.0",<% } %>
6060
"@eslint/js": "^9.27.0",
6161
"@glimmer/component": "^2.0.0<% if (typescript) { %>",
6262
"@glint/core": "^1.5.2",
@@ -75,8 +75,8 @@
7575
"ember-cli": "~6.5.0-beta.0",
7676
"ember-cli-babel": "^8.2.0",
7777
"ember-cli-deprecation-workflow": "^3.3.0<% if (emberData) { %>",
78-
"ember-data": "~5.5.0<% } %>",
79-
"ember-load-initializers": "^3.0.1",
78+
"ember-data": "~5.5.0<% } %>",<% if (compat) { %>
79+
"ember-load-initializers": "^3.0.1",<% } %>
8080
"ember-modifier": "^4.2.2",
8181
"ember-page-title": "^9.0.2",
8282
"ember-qunit": "^9.0.3",

files/vite.config.mjs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ import { extensions, classicEmberSupport, ember } from '@embroider/vite';
33
import { babel } from '@rollup/plugin-babel';
44

55
export default defineConfig({
6-
plugins: [
7-
classicEmberSupport(),
6+
plugins: [<% if (compat) { %>
7+
classicEmberSupport(),<% } %>
88
ember(),
99
// extra plugins here
1010
babel({

index.js

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,16 @@ const stringUtil = require('ember-cli-string-utils');
44
const chalk = require('chalk');
55
const directoryForPackageName = require('./lib/directory-for-package-name');
66

7+
function hasCompat(options) {
8+
let compat = options.compat ?? true;
9+
10+
if (options.noCompat) {
11+
compat = false;
12+
}
13+
14+
return compat;
15+
}
16+
717
module.exports = {
818
description: 'The default blueprint for ember-cli projects.',
919

@@ -59,6 +69,8 @@ module.exports = {
5969
execBinPrefix = 'pnpm';
6070
}
6171

72+
let compat = hasCompat(options);
73+
6274
return {
6375
appDirectory: directoryForPackageName(name),
6476
name,
@@ -79,6 +91,8 @@ module.exports = {
7991
ciProvider: options.ciProvider,
8092
typescript: options.typescript,
8193
packageManager: options.packageManager ?? 'npm',
94+
compat: compat,
95+
noCompat: !compat,
8296
};
8397
},
8498

@@ -106,6 +120,10 @@ module.exports = {
106120
files = files.filter((file) => !file.includes('ember-data/'));
107121
}
108122

123+
if (hasCompat(options)) {
124+
files = files.filter((file) => !file.includes('ember-cli-build.js'));
125+
}
126+
109127
this._files = files;
110128

111129
return this._files;

0 commit comments

Comments
 (0)