Add --minimal and --no-compat

Author: NullVoxPopuli

README.md

@@ -9,3 +9,46 @@ If you have an existing app that you would like to upgrade to use Vite consider
 ```
 pnpm dlx ember-cli@latest new my-app-name -b @ember/app-blueprint --pnpm
 ```
+
+## Options
+
+### `--no-compat`
+
+```
+pnpm dlx ember-cli@latest new my-app-name \
+  --blueprint @ember/app-blueprint@alpha \
+  --pnpm \
+  --no-compat
+```
+
+Does the following:
+- enables `type=module` in package.json (required for vite-ssr, and many ESM tools)
+- makes the build and boot _MUCH FASTER_   
+  (in large apps, this can have your app's boot be up to 1 minute faster)
+- removes `@embroider/compat`
+  - removes support for:
+    - hbs (both for component files, and testing)
+    - content-for (in the HTML files)
+    - v1 addons
+    - node-land config/environment.js
+- removes `ember-cli`
+  - ember-cli brings in a ton of old dependencies, so removing it makes installs much faster
+  - downside though is that you no longer have scaffolding (`ember g`) -- however, you could use `pnpm dlx ember-cli g ...` (or `npx ember-cli g`)
+
+### `--minimal`
+
+```
+pnpm dlx ember-cli@latest new my-app-name \
+  --blueprint @ember/app-blueprint@alpha \
+  --pnpm \
+  --minimal
+```
+
+Does the following
+- everything listed under `--no-compat`
+- Removes all linting, formatting, and testing support
+  - leaves you with a minimal app that you can use for demos, and PRing to other repositories that have multi-framework support (and probably use other testing tools for that multi-framework support)
+- different defaults:
+  - warp-drive becomes _opt-in_ (pass `--warp-drive` if you want it -- normally requires `--no-warp-drive` to remove)
+  - ember-welcome-page becomes _opt-in_ (normally requires `--no-welcome` to remove)
+

index.js

@@ -80,6 +80,8 @@ module.exports = {
           options.packageManager === 'pnpm' && '"--pnpm"',
           options.ciProvider && `"--ci-provider=${options.ciProvider}"`,
           options.typescript && `"--typescript"`,
+          options.minimal && `"--minimal"`,
+          options.noCompat && `"--no-compat"`,
           !options.emberData && `"--no-ember-data"`,
           !options.warpDrive && `"--no-warp-drive"`,
         ]
@@ -101,6 +103,37 @@ module.exports = {
       execBinPrefix = 'pnpm';
     }
 
+    let welcome = options.welcome;
+    let warpDrive = options.warpDrive ?? options.emberData;
+    let minimal = false;
+    let compat = true;
+    /**
+     * --minimal overrides compat/no-compat
+     */
+    if (options.minimal) {
+      minimal = true;
+      compat = false;
+
+      // Invert defaults
+      {
+        welcome = options.welcome = process.argv.includes('--welcome');
+        warpDrive =
+          options.emberData =
+          options.warpDrive =
+            process.argv.includes('--ember-data') ||
+            process.argv.includes('--warp-drive');
+      }
+    }
+
+    if (!minimal) {
+      if (options.noCompat) {
+        compat = false;
+      }
+    }
+
+    let noCompat = !compat;
+    let notMinimal = !minimal;
+
     return {
       appDirectory: directoryForPackageName(name),
       name,
@@ -113,14 +146,18 @@ module.exports = {
         options.packageManager !== 'yarn' && options.packageManager !== 'pnpm',
       invokeScriptPrefix,
       execBinPrefix,
-      welcome: options.welcome,
+      welcome,
       blueprint: 'app',
       blueprintOptions,
       lang: options.lang,
-      warpDrive: options.warpDrive ?? options.emberData,
+      warpDrive: warpDrive,
       ciProvider: options.ciProvider,
       typescript: options.typescript,
       packageManager: options.packageManager ?? 'npm',
+      compat,
+      noCompat,
+      minimal,
+      notMinimal,
     };
   },
 
@@ -131,6 +168,10 @@ module.exports = {
 
     let files = this._super();
 
+    // Locals is where we calculate defaults and such.
+    // Let's not duplicate that work here
+    options = this.locals(options);
+
     if (options.ciProvider !== 'github') {
       files = files.filter((file) => file.indexOf('.github') < 0);
     }
@@ -150,6 +191,43 @@ module.exports = {
       files = files.filter((file) => !file.includes('services/.gitkeep'));
     }
 
+    if (options.noCompat) {
+      files = files.filter((file) => {
+        return (
+          !file.includes('deprecation-workflow') &&
+          !file.includes('ember-cli') &&
+          !file.includes('ember-cli-build.js') &&
+          !file.includes('controllers/') &&
+          !file.includes('config/environment.js') &&
+          !file.includes('config/optional-features') &&
+          !file.includes('config/targets') &&
+          !file.includes('helpers/')
+        );
+      });
+    }
+
+    if (options.minimal) {
+      files = files.filter((file) => {
+        return (
+          !file.includes('.github/') &&
+          !file.includes('.prettierignore') &&
+          !file.includes('README') &&
+          !file.includes('components/') &&
+          !file.includes('eslint.config') &&
+          !file.includes('prettierrc') &&
+          !file.includes('public/') &&
+          !file.includes('routes/') &&
+          !file.includes('services/') &&
+          !file.includes('stylelint') &&
+          !file.includes('styles/') &&
+          !file.includes('template-lintrc') &&
+          !file.includes('testem') &&
+          !file.includes('tests/') &&
+          !file.includes('watchman')
+        );
+      });
+    }
+
     this._files = files;
 
     return this._files;
@@ -182,6 +260,85 @@ module.exports = {
   updatePackageJson(options, content) {
     let contents = JSON.parse(content);
 
+    if (options.minimal) {
+      // Remove linting
+      {
+        delete contents.scripts['format'];
+        delete contents.scripts['lint'];
+        delete contents.scripts['lint:format'];
+        delete contents.scripts['lint:fix'];
+        delete contents.scripts['lint:js'];
+        delete contents.scripts['lint:js:fix'];
+        delete contents.scripts['lint:css'];
+        delete contents.scripts['lint:css:fix'];
+        delete contents.scripts['lint:hbs'];
+        delete contents.scripts['lint:hbs:fix'];
+
+        delete contents.devDependencies['@babel/eslint-parser'];
+        delete contents.devDependencies['@eslint/js'];
+        delete contents.devDependencies['concurrently'];
+        delete contents.devDependencies['ember-template-lint'];
+        delete contents.devDependencies['eslint'];
+        delete contents.devDependencies['eslint-config-prettier'];
+        delete contents.devDependencies['eslint-plugin-ember'];
+        delete contents.devDependencies['eslint-plugin-n'];
+        delete contents.devDependencies['eslint-plugin-qunit'];
+        delete contents.devDependencies['eslint-plugin-warp-drive'];
+        delete contents.devDependencies['globals'];
+        delete contents.devDependencies['prettier'];
+        delete contents.devDependencies['prettier-plugin-ember-template-tag'];
+        delete contents.devDependencies['stylelint'];
+        delete contents.devDependencies['stylelint-config-standard'];
+        delete contents.devDependencies['typescript-eslint'];
+      }
+      // Remove testing
+      {
+        delete contents.scripts['test'];
+        delete contents.devDependencies['@ember/test-helpers'];
+        delete contents.devDependencies['@ember/test-waiters'];
+        delete contents.devDependencies['ember-qunit'];
+        delete contents.devDependencies['qunit'];
+        delete contents.devDependencies['qunit-dom'];
+        delete contents.devDependencies['testem'];
+      }
+      // Extraneous / non-core deps.
+      // if folks go minimal, they know what they are doing
+      {
+        delete contents.devDependencies['ember-welcome-page'];
+        delete contents.devDependencies['tracked-built-ins'];
+        delete contents.devDependencies['ember-page-title'];
+        delete contents.devDependencies['ember-modifier'];
+      }
+      // common-in-the-vite-ecosystem alias
+      {
+        contents.scripts.dev = contents.scripts.start;
+      }
+    }
+    if (options.noCompat) {
+      contents.type = 'module';
+      contents.engines.node = '>= 24';
+      delete contents.directories;
+      delete contents.devDependencies['@ember/string'];
+      delete contents.devDependencies['@ember/optional-features'];
+      delete contents.devDependencies['@embroider/compat'];
+      delete contents.devDependencies['@embroider/config-meta-loader'];
+      delete contents.devDependencies['ember-resolver'];
+      // Users should use npx ember-cli instead
+      delete contents.devDependencies['ember-cli'];
+      delete contents.devDependencies['ember-cli-babel'];
+      delete contents.devDependencies['ember-load-initializers'];
+      // This arguable should still exist, but it's a v1 addon
+      delete contents.devDependencies['ember-cli-deprecation-workflow'];
+
+      // A nice feature of modern apps is using sub-path imports
+      // Why specify the whole app name, when you can use `#`?
+      contents.imports = {
+        '#app/*': './app/*',
+        '#config': './app/config/environment',
+        '#components/*': './app/components/*',
+      };
+    }
+
     return stringifyAndNormalize(sortPackageJson(contents));
   },
 };