imapclient: fix FetchItems to end encoded list

adregner · emersion · commit a36346654c50 · 2023-07-02T09:37:14.000+02:00
#517 uses the new `enc.BeginList()` to encode fetch options over the IMAP protocol, but never calls `.End()` so the closing `)` character is never written out, causing errors like `T6 BAD Could not parse command`.
diff --git a/imapclient/fetch.go b/imapclient/fetch.go
@@ -74,6 +74,8 @@ func writeFetchItems(enc *imapwire.Encoder, uid bool, options *imap.FetchOptions
 	for _, bss := range options.BinarySectionSize {
 		writeFetchItemBinarySectionSize(listEnc.Item(), bss)
 	}
+
+	listEnc.End()
 }
 
 func writeFetchItemBodySection(enc *imapwire.Encoder, item *imap.FetchItemBodySection) {

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,8 @@ func writeFetchItems(enc imapwire.Encoder, uid bool, options imap.FetchOptions`
`74`	`74`	`for _, bss := range options.BinarySectionSize {`
`75`	`75`	`writeFetchItemBinarySectionSize(listEnc.Item(), bss)`
`76`	`76`	`}`
	`77`	`+`
	`78`	`+ listEnc.End()`
`77`	`79`	`}`
`78`	`80`
`79`	`81`	`func writeFetchItemBodySection(enc imapwire.Encoder, item imap.FetchItemBodySection) {`