-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Add support for TRUSTED_TYPES when using Wasm Workers #23767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sbc100
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we need some kind of test for this?
We do have an existing test for TRUSTED_TYPES in |
When you say add a variation that matches the existing Lines 13161 to 13165 in 88ffcb9
So something like |
|
Yup that looks about right. |
Head branch was pushed to by a user without write access
|
It seems like there's still a CI failing, any idea what may be causing that? I see it says |
|
I think maybe you should try reverting |
This change allows usage of Trusted Types compatible wrappers for Wasm Workers when
TRUSTED_TYPESis defined.Similar behavior has already been implemented in libpthread.js, so the changes here are based off of & exhibit the same logic used for Trusted Types & pthread compatibility.