refactor(ses-ava): Remove use of ambient process from main (#3002)

Author: gibson042

packages/ses-ava/bin/ses-ava.cjs

@@ -1,8 +1,13 @@
 #!/usr/bin/env node
 (async () => {
   const { main } = await import('../src/command.js');
-  await main(process.argv.slice(2));
-})().catch(error => {
-  console.error(error);
-  process.exitCode = 1;
-});
+  return main(process.argv.slice(2));
+})().then(
+  exitCode => {
+    process.exitCode ||= exitCode;
+  },
+  error => {
+    console.error(error);
+    process.exitCode ||= 1;
+  },
+);

packages/ses-ava/src/command.js

@@ -1,4 +1,3 @@
-/* global process */
 /* eslint-disable no-await-in-loop, no-continue, no-labels, no-unreachable-loop */
 
 /* The ses-ava command allows a single package to run the same test suite with
@@ -39,7 +38,8 @@ const passThroughArgOptions = new Set([
   '--port',
 ]);
 
-export const main = async () => {
+/** @type {(args: string[]) => Promise<number>} */
+export const main = async args => {
   // Parse configuration.
   const descriptorText = await fs.promises.readFile('package.json', 'utf8');
   const descriptor = JSON.parse(descriptorText);
@@ -54,7 +54,7 @@ export const main = async () => {
   const onlyConfigNames = new Set();
   let failFast = false;
   let firstArg = true;
-  const argsIterator = process.argv.slice(2)[Symbol.iterator]();
+  const argsIterator = args[Symbol.iterator]();
   for (const rawArg of argsIterator) {
     if (rawArg === '--') {
       passThroughArgs.push(...argsIterator);
@@ -137,6 +137,7 @@ export const main = async () => {
   }
 
   // Execute configurations serially.
+  let exitCode = 0;
   for (const config of configs) {
     console.warn(`[ses-ava] config:`, config);
     const avaArgs = [
@@ -146,17 +147,16 @@ export const main = async () => {
     const child = popen.spawn('ava', avaArgs, {
       stdio: ['inherit', 'inherit', 'inherit'],
     });
-    await new Promise((resolve, reject) => {
-      child.on('exit', code => {
-        process.exitCode ||= typeof code === 'number' ? code : 1;
-        if (failFast && process.exitCode !== 0) {
-          process.exit();
-        }
-        resolve(undefined);
+    const configExitCode = await new Promise((resolve, reject) => {
+      child.on('exit', (code, _signal) => {
+        resolve(typeof code === 'number' ? code : 1);
       });
       child.on('error', error => {
         reject(error);
       });
     });
+    exitCode ||= configExitCode;
+    if (failFast && exitCode !== 0) break;
   }
+  return exitCode;
 };