Synchronously increment loading counter before coroutine launch to avoid UI flickering in edge cases

Author: wkornewald

CHANGELOG.md

@@ -13,6 +13,7 @@
 * Renamed modules: `reactivestate` -> `reactivestate-android`, `reactivestate-test` -> `reactivestate-android-test`. You might only want to use `reactivestate-compose` in case you don't need to add ViewModels to Activities/Fragments.
 * Fixed `MutableStateFlow.compareAndSet` for `.toMutable`/`.beforeUpdate`/`.afterUpdate`.
 * Added `Flow.stateOnDemand` variant with `initial` value.
+* `CoroutineLauncher.launch` now synchronously increments the loading counter to avoid UI flickering issues in edge cases.
 
 ## 5.13.0
 

reactivestate-core/src/commonMain/kotlin/com/ensody/reactivestate/CoroutineLauncher.kt

@@ -56,12 +56,19 @@ public interface CoroutineLauncher {
         withLoading: MutableStateFlow<Int>? = loading,
         onError: (suspend (Throwable) -> Unit)? = null,
         block: suspend CoroutineScope.() -> Unit,
-    ): Job =
-        rawLaunch(context = context, start = start) {
-            track(withLoading = withLoading, onError = onError) {
-                block()
+    ): Job {
+        // Increment before coroutine launch to avoid UI flickering in edge cases
+        withLoading?.increment()
+        return rawLaunch(context = context, start = start) {
+            withErrorReporting({ onError?.invoke(it) ?: onError(it) }) {
+                try {
+                    block()
+                } finally {
+                    withLoading?.decrement()
+                }
             }
         }
+    }
 
     /**
      * Tracks a suspension [block]'s loading state and errors.