fix-comments

Signed-off-by: yxia216 <[email protected]>

Author: hustxiayang

internal/apischema/openai/openai.go

@@ -1583,8 +1583,8 @@ type GCPVertexAIGenerationConfig struct {
 	// https://cloud.google.com/vertex-ai/docs/reference/rest/v1/GenerationConfig#ThinkingConfig
 	ThinkingConfig *genai.ThinkingConfig `json:"thinkingConfig,omitzero"`
 
-	// Detail here is to set global media resolution in gemini models: https://ai.google.dev/api/caching#MediaResolution
-	Detail genai.MediaResolution `json:"detail,omitempty"`
+	// MediaResolution is to set global media resolution in gemini models: https://ai.google.dev/api/caching#MediaResolution
+	MediaResolution genai.MediaResolution `json:"media_resolution,omitempty"`
 }
 
 // AnthropicVendorFields contains Anthropic vendor-specific fields.

internal/apischema/openai/vendor_fields_test.go

@@ -232,7 +232,7 @@ func TestChatCompletionRequest_VendorFieldsExtraction(t *testing.T) {
 					}
 				],
 				"generationConfig": {
-					"detail": "high"
+					"media_resolution": "high"
 				}
 			}`),
 			expected: &ChatCompletionRequest{
@@ -247,7 +247,7 @@ func TestChatCompletionRequest_VendorFieldsExtraction(t *testing.T) {
 				},
 				GCPVertexAIVendorFields: &GCPVertexAIVendorFields{
 					GenerationConfig: &GCPVertexAIGenerationConfig{
-						Detail: "high",
+						MediaResolution: "high",
 					},
 				},
 			},
@@ -263,7 +263,7 @@ func TestChatCompletionRequest_VendorFieldsExtraction(t *testing.T) {
 					}
 				],
 				"generationConfig": {
-					"detail": "medium",
+					"media_resolution": "medium",
 					"thinkingConfig": {
 						"includeThoughts": true,
 						"thinkingBudget": 500
@@ -282,7 +282,7 @@ func TestChatCompletionRequest_VendorFieldsExtraction(t *testing.T) {
 				},
 				GCPVertexAIVendorFields: &GCPVertexAIVendorFields{
 					GenerationConfig: &GCPVertexAIGenerationConfig{
-						Detail: "medium",
+						MediaResolution: "medium",
 						ThinkingConfig: &genai.ThinkingConfig{
 							IncludeThoughts: true,
 							ThinkingBudget:  ptr.To(int32(500)),

internal/translator/openai_gcpvertexai.go

@@ -448,8 +448,8 @@ func (o *openAIToGCPVertexAITranslatorV1ChatCompletion) applyVendorSpecificField
 		if vendorGenConfig.ThinkingConfig != nil {
 			gcr.GenerationConfig.ThinkingConfig = vendorGenConfig.ThinkingConfig
 		}
-		if vendorGenConfig.Detail != "" {
-			gcr.GenerationConfig.MediaResolution = vendorGenConfig.Detail
+		if vendorGenConfig.MediaResolution != "" {
+			gcr.GenerationConfig.MediaResolution = vendorGenConfig.MediaResolution
 		}
 	}
 	if gcpVendorFields.SafetySettings != nil {

internal/translator/openai_gcpvertexai_test.go

@@ -641,7 +641,7 @@ func TestOpenAIToGCPVertexAITranslatorV1ChatCompletion_RequestBody(t *testing.T)
 				},
 				GCPVertexAIVendorFields: &openai.GCPVertexAIVendorFields{
 					GenerationConfig: &openai.GCPVertexAIGenerationConfig{
-						Detail: "high",
+						MediaResolution: "high",
 					},
 				},
 			},