Support Gauge in access_loggers.stats #42226
Conversation
Signed-off-by: Xuyang Tao <[email protected]>
TAOXUY
requested review from
ggreenway,
kyessenov and
wbpcode
as code owners
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
TAOXUY
changed the title
| // A fixed value to add to this counter. | ||
| // One of ``value_format`` or ``value_fixed`` must be configured. |
There was a problem hiding this comment.
This comment needs to be updated for how it relates to the gauge operations.
Signed-off-by: Xuyang Tao <[email protected]>
| google.protobuf.UInt64Value value_fixed = 3 [(validate.rules).uint64 = {gt: 0}]; | ||
| } | ||
|
|
||
| // Configuration for a gauge stat. |
There was a problem hiding this comment.
I think it's quite tricky to use a gauge correctly (to avoid "leaking" of counts). Please add documentation on correct and incorrect ways this could be configured, with some examples.
Signed-off-by: Xuyang Tao <[email protected]>
Signed-off-by: Xuyang Tao <[email protected]>
|
|
||
| // The access log type to emit this gauge. If set, the gauge will only be | ||
| // emitted for the specified access log type. | ||
| data.accesslog.v3.AccessLogType access_log_type = 5; |
There was a problem hiding this comment.
This seems like it should be common to all types (counters and histograms). Should this be part of message Stat? Or should it be a top-level configuration on the logger, and user defines multiple loggers, one for each desired value?
3 participants
Commit Message: add gauge support in access_loggers.stats
Risk Level:low
Testing:both unit test and integration test are added
Docs Changes: updated in the protobuf comments
Release Notes: updated
Platform Specific Features:no