Commit c42b366
authored
Revert "Remove duplicates from AccHistory and StorageHistory" (#18109)
Reverts #17962
<@525860938360815626> : Mike prepared a DB with commitments enabled for
historical eth_getProof() verifications.
Upon executing the historical tests, we observed that the state root
calculation failed for few tests with postState and so verification of
receiptsRoot(the calculated receipt root doesn't match
block.receiptRoot).
Previously, even when running the Hive tests (with commitment enabled),
the state root calculation was correct.
By bisecting the commits, we identified that the failure was introduced
after the merge of PR #17962.
PR #18108 enables historical tests with Erigon commitments and inserts
two calls to TouchKey() in DomainPut(). This addition resolves the
failed state root calculation and the verification of the receipts root.
Since I am not an expert in this specific code component, could you
please verify if this is the correct fix?1 parent e565e1a commit c42b366
File tree
3 files changed
+4
-6
lines changed- db
- kv/kvcache
- state/execctx
- rpc/jsonrpc
3 files changed
+4
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
171 | 171 | | |
172 | 172 | | |
173 | 173 | | |
174 | | - | |
175 | 174 | | |
176 | 175 | | |
177 | 176 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
357 | 357 | | |
358 | 358 | | |
359 | 359 | | |
| 360 | + | |
360 | 361 | | |
361 | 362 | | |
362 | 363 | | |
| |||
366 | 367 | | |
367 | 368 | | |
368 | 369 | | |
369 | | - | |
| 370 | + | |
370 | 371 | | |
371 | 372 | | |
372 | 373 | | |
373 | | - | |
| 374 | + | |
374 | 375 | | |
375 | 376 | | |
376 | 377 | | |
377 | 378 | | |
378 | 379 | | |
379 | 380 | | |
380 | | - | |
381 | | - | |
382 | 381 | | |
383 | 382 | | |
384 | 383 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
383 | 383 | | |
384 | 384 | | |
385 | 385 | | |
386 | | - | |
| 386 | + | |
387 | 387 | | |
388 | 388 | | |
389 | 389 | | |
| |||
0 commit comments