fix: Get(nil) fast-path and return correct first offset #18093
+34
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BpsTree.Get(nil) incorrectly returned “not found” because the fast-path tested if err != nil || k0 != nil, which treats the presence of the first key as an error. This contradicts the function comment and the behavior of Seek(nil), both of which expect the first key to be returned when the key is empty. It also contradicts the dataLookup contract that a valid di returns a non-nil key/value. The fix removes the k0 != nil condition and returns the first record’s actual offset obtained from dataLookup. A new test asserts that Get(nil) returns found == true, the first key’s value, and the correct first offset, ensuring consistency with the index and preventing regressions.