qa-tests: rpc integration with commitment #18108
Merged
+15
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AskAlexSharov
added a commit
that referenced
this pull request
Nov 30, 2025
Reverts #17962 <@525860938360815626> : Mike prepared a DB with commitments enabled for historical eth_getProof() verifications. Upon executing the historical tests, we observed that the state root calculation failed for few tests with postState and so verification of receiptsRoot(the calculated receipt root doesn't match block.receiptRoot). Previously, even when running the Hive tests (with commitment enabled), the state root calculation was correct. By bisecting the commits, we identified that the failure was introduced after the merge of PR #17962. PR #18108 enables historical tests with Erigon commitments and inserts two calls to TouchKey() in DomainPut(). This addition resolves the failed state root calculation and the verification of the receipts root. Since I am not an expert in this specific code component, could you please verify if this is the correct fix?
lupin012
force-pushed
the
qa-tests/rpc_integration_with_getproof
branch
from
14692ae to
ba522a4
Compare
lupin012
force-pushed
the
qa-tests/rpc_integration_with_getproof
branch
from
ba522a4 to
1686043
Compare
mriccobene
requested changes
Dec 1, 2025
Removed 'eth_getBlockReceipts/test_01.json' from the disabled tests list.
mriccobene
approved these changes
Dec 1, 2025
canepat
changed the title
canepat
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.