tests: fix statetest message construction to match other clients #18121
+6
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when post.Tx (txbytes) was present in state tests, erigon would override the message constructed from the transaction JSON with one derived from the raw transaction bytes. This caused inconsistencies because the txbytes could have different values (e.g., gas limit) than the transaction JSON fields. Other clients (go-ethereum, nethermind, besu) only use txbytes for validation purposes, not to replace the message. This fix aligns erigon with other clients by: 1. Adding BlobVersionedHashes field to stTransaction struct (previously missing, which was the original reason for the txbytes workaround) 2. Using BlobVersionedHashes in toMessage() when constructing messages 3. Removing the txbytes override logic that incorrectly replaced the message for all transaction types This fixes gas calculation mismatches where erigon would report different initial gas than other clients due to the txbytes having a different gas limit than the transaction JSON. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18079
Previously, when post.Tx (txbytes) was present in state tests, erigon would override the message constructed from the transaction JSON with one derived from the raw transaction bytes. This caused inconsistencies because the txbytes could have different values (e.g., gas limit) than the transaction JSON fields.
Other clients (go-ethereum, nethermind, besu) only use txbytes for validation purposes, not to replace the message. This fix aligns erigon with other clients by:
This fixes gas calculation mismatches where erigon would report different initial gas than other clients due to the txbytes having a different gas limit than the transaction JSON.
🤖 Generated with Claude Code