Add warning to prevent flicker #5494
Conversation
Due to combination of specific ESP32 boards, RMT component and wifi, it seems some ESPhome builds result in significant flicker on addressable LEDs. It has been tracked in defect esphome/esphome#10335 and the solution seems to work OK for multiple people.
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Rate limit exceeded@sanchosk has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 48 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughAdded an important note to the ESP32 RMT LED Strip documentation about possible flicker on longer LED strips and instructing users to disable Wi‑Fi power saving ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
content/components/light/esp32_rmt_led_strip.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
- Do not generate or add any sequence diagrams
Files:
content/components/light/esp32_rmt_led_strip.md
🪛 GitHub Actions: Lint
content/components/light/esp32_rmt_led_strip.md
[error] 20-20: markdownlint: MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines.
| ``` | ||
| **Important note** In some specific cases, the RMT component might cause flicker of longer LED strips. The fix seem to be to disable the wifi power saving by setting | ||
| [power_save_mode](/components/wifi/#power-save-mode) to none in [wifi component](/components/wifi). |
There was a problem hiding this comment.
Fix markdown formatting and grammar issues.
- Markdown linting error: Line 20 ends the code fence, but line 21 immediately follows without a blank line. Markdown fenced blocks should be surrounded by blank lines (addresses pipeline failure MD031).
- Grammar: "The fix seem to be" should be "The fix seems to be" (subject-verb agreement).
- Capitalization: "wifi" should be "Wi-Fi" per standard branding.
- Text flow: The note awkwardly breaks across lines 21–22. Reformat for clarity.
Apply this diff:
```yaml
light:
- platform: esp32_rmt_led_strip
rgb_order: GRB
pin: GPIOXX
num_leds: 30
chipset: ws2812
name: "My Light"-Important note In some specific cases, the RMT component might cause flicker of longer LED strips. The fix seem to be to disable the wifi power saving by setting
- power_save_mode to none in wifi component.
+Important note: In some specific cases, the RMT component might cause flicker on longer LED strips. The fix seems to be disabling Wi-Fi power saving by setting power_save_mode tononein the Wi-Fi component.
<details>
<summary>🧰 Tools</summary>
<details>
<summary>🪛 GitHub Actions: Lint</summary>
[error] 20-20: markdownlint: MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines.
</details>
<details>
<summary>🪛 GitHub Check: build</summary>
[failure] 20-20:
Fenced code blocks should be surrounded by blank lines [Context: "```"]
</details>
</details>
<details>
<summary>🤖 Prompt for AI Agents</summary>
In content/components/light/esp32_rmt_led_strip.md around lines 20–22, fix the
markdown and wording: ensure the fenced code block is surrounded by a blank
line, change "The fix seem to be" to "The fix seems to be", capitalize "Wi-Fi"
everywhere, add a colon after "Important note", reword "flicker of longer LED
strips" to "flicker on longer LED strips", and format the power_save_mode value
as inline code and the Wi‑Fi component name consistently while keeping the
existing links.
</details>
<!-- This is an auto-generated comment by CodeRabbit -->
sorry...
Not sure this is the problem...
1 participant
Due to combination of specific ESP32 boards, RMT component and wifi, it seems some ESPhome builds result in significant flicker on addressable LEDs. It has been tracked in defect esphome/esphome#10335 and the solution seems to work OK for multiple people.
Description:
Related issue (if applicable): fixes
Pull request in esphome with YAML changes (if applicable):
Checklist:
I am merging into
nextbecause this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
currentbecause this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/components/index.rstwhen creating new documents for new components or cookbook.