Skip to content

Conversation

@DakshitBabbar
Copy link
Contributor

@DakshitBabbar DakshitBabbar commented Mar 17, 2025

Description

This PR is created along with this PR to update the code for a clean build with the latest ESP-IDF v5.4.

This PR:

  • Updates the code remove the constness related warnings with the latest ESP-IDF v5.4.

Related

Testing

The code is building successfully with the latest ESP-IDF v5.4


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@CLAassistant
Copy link

CLAassistant commented Mar 17, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title Update code to remove constness related warnings for lates ESP-IDF v5.4 Update code to remove constness related warnings for lates ESP-IDF v5.4 (CA-354) Mar 17, 2025
@cmorganBE
Copy link

Can we get this merged? Seeing the cbor build issue in #198 for months now.

@cmorganBE
Copy link

@aggarg any updates here? I'm pulling a fresh repo and hitting this again (since I haven't manually applied the fix).

@aggarg
Copy link

aggarg commented Jun 21, 2025

Let me check and get back on this.

@DakshitBabbar DakshitBabbar marked this pull request as ready for review June 30, 2025 06:59
@DakshitBabbar
Copy link
Contributor Author

Hi, apologies for the delay in completing this PR. It’s now ready for review and merge. Kindly take a look when convenient. Thank you!

@DakshitBabbar DakshitBabbar changed the title Update code to remove constness related warnings for lates ESP-IDF v5.4 (CA-354) Update code to remove constness related warnings for latest ESP-IDF v5.4 (CA-354) Jun 30, 2025
@avsheth avsheth merged commit 0283c54 into espressif:master Jul 16, 2025
1 check passed
@DakshitBabbar DakshitBabbar deleted the esp32-ci-updates branch July 23, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants