Skip to content

Commit e6c3452

Browse files
authored
Do not push files to consensus-spec-tests (#4678)
I'm not sure how to fix this issue in the release action. Something is wrong with the runner or with git lfs. For this reason, this PR updates the release action to **not** push to the consensus-spec-tests repo. We can try to deprecate this repo. Spec tests are now included in the consensus-specs release. This should be a fairly small change for clients.
1 parent 3e91f0d commit e6c3452

File tree

1 file changed

+0
-58
lines changed

1 file changed

+0
-58
lines changed

.github/workflows/release.yml

Lines changed: 0 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -43,28 +43,6 @@ jobs:
4343
exit 1
4444
fi
4545
46-
# Add support for large files
47-
- name: Install Git LFS
48-
run: |
49-
sudo apt-get update
50-
sudo apt-get install -y git-lfs
51-
git lfs install
52-
53-
# Clone the repo with our PAT and delete old files
54-
- name: Clone spec tests repo
55-
run: |
56-
rm -rf consensus-spec-tests
57-
git clone https://x-access-token:${{ secrets.CONSENSUS_SPEC_TESTS_PAT }}@github.com/ethereum/consensus-spec-tests.git --branch=master --single-branch --no-tags
58-
cd consensus-spec-tests
59-
git rm -rf configs presets tests
60-
61-
# Write presets/configs to the spec tests repo
62-
- name: Copy presets/configs
63-
run: |
64-
cd consensus-specs
65-
cp -r presets/ ../consensus-spec-tests/presets
66-
cp -r configs/ ../consensus-spec-tests/configs
67-
6846
# Write reference tests to the spec tests repo
6947
- name: Generate reference tests
7048
run: |
@@ -79,21 +57,6 @@ jobs:
7957
tar -czvf minimal.tar.gz tests/minimal
8058
tar -czvf mainnet.tar.gz tests/mainnet
8159
82-
# Commit the tests to the spec tests repo
83-
# Cloned with PAT, so don't need to specify it here
84-
- name: Push spec tests
85-
run: |
86-
cd consensus-spec-tests
87-
git config user.name "github-actions"
88-
git config user.email "[email protected]"
89-
git add --all
90-
if ! git diff --cached --quiet; then
91-
git commit -m "release ${{ github.ref_name }} tests"
92-
git push origin HEAD:refs/heads/master
93-
else
94-
echo "No changes to commit"
95-
fi
96-
9760
# Publish the specs release. We use release-drafter to
9861
# organize PRs into the appropriate section based on PR labels
9962
- name: Publish specs release
@@ -117,24 +80,3 @@ jobs:
11780
consensus-spec-tests/mainnet.tar.gz
11881
env:
11982
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
120-
121-
# Finally, publish the spec tests release
122-
# Requires a personal access token (PAT) with contents:read-write
123-
- name: Publish spec tests release
124-
uses: softprops/action-gh-release@6da8fa9354ddfdc4aeace5fc48d7f679b5214090 # v2.4.1
125-
with:
126-
tag_name: ${{ github.ref_name }}
127-
name: "Spec tests for ${{ github.ref_name }}"
128-
body: |
129-
Spec tests for `${{ github.ref_name }}`.
130-
131-
Detailed changelog can be found in [`${{ github.ref_name }}` specs release](https://github.com/ethereum/consensus-specs/releases/tag/${{ github.ref_name }}).
132-
prerelease: ${{ contains(github.ref_name, '-') }}
133-
draft: false
134-
repository: ethereum/consensus-spec-tests
135-
files: |
136-
consensus-spec-tests/general.tar.gz
137-
consensus-spec-tests/minimal.tar.gz
138-
consensus-spec-tests/mainnet.tar.gz
139-
env:
140-
GITHUB_TOKEN: ${{ secrets.CONSENSUS_SPEC_TESTS_PAT }}

0 commit comments

Comments
 (0)