Skip to content

fix: download buttons for png and svg #16657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pettinarip merged 2 commits into from
Dec 3, 2025
Merged

fix: download buttons for png and svg #16657

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54a207d
fix: download buttons for png and svg
corwintines Nov 15, 2025
ec6dda2
refactor: replace download handling with ButtonLink for direct file d…
corwintines Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions src/components/AssetDownload/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,12 @@ import type { ImageProps, StaticImageData } from "next/image"

import AssetDownloadArtist from "@/components/AssetDownload/AssetDownloadArtist"
import AssetDownloadImage from "@/components/AssetDownload/AssetDownloadImage"
import { ButtonLink } from "@/components/ui/buttons/Button"
import { Flex, Stack } from "@/components/ui/flex"

import { cn } from "@/lib/utils/cn"
import { trackCustomEvent } from "@/lib/utils/matomo"

import { ButtonLink } from "../ui/buttons/Button"
import { Flex, Stack } from "../ui/flex"

import { useTranslation } from "@/hooks/useTranslation"

type AssetDownloadProps = {
Expand Down Expand Up @@ -41,7 +40,9 @@ const AssetDownload = ({
eventName: title,
})
}

const imgSrc = (image as StaticImageData).src
const fileExtension = extname(imgSrc).slice(1)

return (
<Stack
Expand All @@ -56,12 +57,19 @@ const AssetDownload = ({
)}
</div>
<Flex className="mt-4 gap-5">
<ButtonLink href={imgSrc} onClick={matomoHandler} target="_blank">
{t("page-assets-download-download")} (
{extname(imgSrc).slice(1).toUpperCase()})
<ButtonLink
href={imgSrc}
onClick={matomoHandler}
download={`${title.replace(/\s+/g, "-").toLowerCase()}.${fileExtension}`}
>
{t("page-assets-download-download")} ({fileExtension.toUpperCase()})
</ButtonLink>
{svgUrl && (
<ButtonLink href={svgUrl} onClick={matomoHandler} target="_blank">
<ButtonLink
href={svgUrl}
onClick={matomoHandler}
download={`${title.replace(/\s+/g, "-").toLowerCase()}.svg`}
>
{t("page-assets-download-download")} (SVG)
</ButtonLink>
)}
Expand Down