Skip to content

Commit e3f36eb

Browse files
authored
chore(test-tools): re-enable eip checklist docs unit tests (#1740)
* Unskip checklist template consistency tests Removed skip markers from checklist template tests. * Update test_eip_checklist.py * Update test_checklist_template_consistency.py * Fix template path in test_checklist_template_consistency * Define TEMPLATE_PATH for checklist templates Add TEMPLATE_PATH for accessing checklist templates. * Fix path to EIP checklist template * Import Path from pathlib in test_eip_checklist.py * Fix TEMPLATE_PATH by adjusting parent directory count * Update TEMPLATE_PATH to correct parent directory * Remove unused TEMPLATE_PATH from test_eip_checklist.py Removed unused TEMPLATE_PATH definition from test file. * Fix template path for EIP testing checklist * Update test_eip_checklist.py * Update test_eip_checklist.py * Fix indentation in test_eip_checklist.py * Simplify TEMPLATE_PATH using Path.parents * Update assert_outcomes to include passed, failed, skipped * chore: remove unused pytest import * style: apply automatic code formatting and fix lint
1 parent 768a9b4 commit e3f36eb

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

packages/testing/src/execution_testing/checklists/tests/test_checklist_template_consistency.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
from execution_testing.checklists.eip_checklist import EIPChecklist
1010

1111
TEMPLATE_PATH = (
12-
Path(__file__).parent.parent.parent.parent
12+
Path(__file__).parents[6]
1313
/ "docs"
1414
/ "writing_tests"
1515
/ "checklist_templates"
@@ -60,7 +60,6 @@ def get_all_checklist_ids(obj: Any) -> Set[str]:
6060
return ids
6161

6262

63-
@pytest.mark.skip(reason="Skipping test until ./docs/ folder is subtree'd")
6463
def test_checklist_template_consistency() -> None:
6564
"""
6665
Test that all IDs in markdown template match EIPChecklist class exactly.
@@ -101,7 +100,6 @@ def test_checklist_template_consistency() -> None:
101100
pytest.fail(error_message)
102101

103102

104-
@pytest.mark.skip(reason="Skipping test until ./docs/ folder is subtree'd")
105103
def test_checklist_template_exists() -> None:
106104
"""Test that the checklist template file exists."""
107105
assert TEMPLATE_PATH.exists(), (

packages/testing/src/execution_testing/cli/pytest_commands/plugins/filler/eip_checklist.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ def pytest_addoption(parser: pytest.Parser) -> None:
5151
PERCENTAGE_LINE = (
5252
"| TOTAL_CHECKLIST_ITEMS | COVERED_CHECKLIST_ITEMS | PERCENTAGE |"
5353
)
54-
TEMPLATE_PATH = Path(
55-
# TODO: add better repo root detection
54+
55+
TEMPLATE_PATH = (
5656
Path(__file__).parents[8]
5757
/ "docs"
5858
/ "writing_tests"

packages/testing/src/execution_testing/cli/pytest_commands/plugins/filler/tests/test_eip_checklist.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,7 @@
44
import textwrap
55
from typing import Any
66

7-
import pytest
87

9-
10-
@pytest.mark.skip(reason="S kipping test until ./docs/ folder is subtree'd")
118
def test_eip_checklist_collection(testdir: Any) -> None:
129
"""Test that checklist markers are collected correctly."""
1310
# Create the test in an EIP-specific directory

0 commit comments

Comments
 (0)