feat(tests): Port oog create refund test; add BAL >= Amsterdam #1831
+439
−489
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
I worked to port the test that caught this issue in the static tests as I think this was a good opportunity for porting while being able to add the BAL expectation for >= Amsterdam.
The parametrized case for code_deposit filled but failed BAL check against Amsterdam, still recording the writes.
This adds a fix as we should pass the appropriate parent call frame to the
execute_codefunction so we can more appropriately track themerge_on_failure/merge_on_successpart of the frame conclusion.✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture