all: introduce codedb and simplify cachingDB #33097
Open
+447
−289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
requested review from
MariusVanDerWijden,
fjl,
lightclient and
s1na
as code owners
lucia-w
reviewed
Nov 9, 2025
lucia-w
reviewed
Nov 9, 2025
lucia-w
reviewed
Nov 9, 2025
weiihann
reviewed
Dec 9, 2025
Contributor
weiihann
left a comment
weiihann
left a comment
There was a problem hiding this comment.
LGTM. Added few nitpicks but they don't matter too much.
Comment on lines
+246
to
+253
| codeFlag := make(map[common.Hash]bool) | ||
| for _, code := range update.codes { | ||
| if code.exists || codeFlag[code.hash] { | ||
| continue | ||
| } | ||
| stats.ContractCodes += 1 | ||
| stats.ContractCodeBytes += codeKeySize + int64(len(code.blob)) | ||
| codeFlag[code.hash] = true |
Contributor
There was a problem hiding this comment.
Suggested change
| codeFlag := make(map[common.Hash]bool) | |
| for _, code := range update.codes { | |
| if code.exists || codeFlag[code.hash] { | |
| continue | |
| } | |
| stats.ContractCodes += 1 | |
| stats.ContractCodeBytes += codeKeySize + int64(len(code.blob)) | |
| codeFlag[code.hash] = true | |
| codeFlag := make(map[common.Hash]struct{}) | |
| for _, code := range update.codes { | |
| if _, ok := codeFlag[code.hash]; ok || !code.exists { | |
| continue | |
| } | |
| stats.ContractCodes += 1 | |
| stats.ContractCodeBytes += codeKeySize + int64(len(code.blob)) | |
| codeFlag[code.hash] = struct{}{} | |
| } |
Comment on lines
+188
to
+197
| cache := make(map[common.Hash]bool) | ||
| for addr, code := range sc.codes { | ||
| if exists, ok := cache[code.hash]; ok { | ||
| code.exists = exists | ||
| continue | ||
| } | ||
| res := reader.Has(addr, code.hash) | ||
| cache[code.hash] = res | ||
| code.exists = res | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the codeDB implementation is introduced and integrated into the blockchain
as a long-term object shared between chain processing and RPC queries.
This serves as a prerequisite for the upcoming StateDB refactoring.