Commit error for UBR corrrected

Author: hecmas

results.md

@@ -22,18 +22,18 @@ How to read this report:
 - Grinding (bits): 0
 - Field: Goldilocks³
 - Rate (ρ): 0.5
-- Trace length (H): $2^{22}$
+- Trace length (H): $2^{16}$
 - FRI folding factor: 16
 - FRI early stop degree: 32
 - Batching: Powers
 
-**Proof Size Estimate:** 992 KiB, where 1 KiB = 1024 bytes
+**Proof Size Estimate:** 24678 KiB, where 1 KiB = 1024 bytes
 
-| regime | total | ALI | DEEP | FRI batching round | FRI commit rounds (×5) | FRI query phase |
-| --- | --- | --- | --- | --- | --- | --- |
-| UDR | 53 | 185 | 167 | 162 | 165 | 53 |
-| JBR | 58 | 181 | 163 | 142 | 159 | 58 |
-| best attack | 128 | — | — | — | — | — |
+| regime | total | ALI | DEEP | FRI batching round | FRI commit round 1 | FRI commit round 2 | FRI commit round 3 | FRI query phase |
+| --- | --- | --- | --- | --- | --- | --- | --- | --- |
+| UDR | 53 | 180 | 173 | 163 | 175 | 179 | 183 | 53 |
+| JBR | 58 | 175 | 169 | 141 | 153 | 157 | 161 | 58 |
+| best attack | 128 | — | — | — | — | — | — | — |
 
 ## Miden
 
@@ -51,11 +51,11 @@ How to read this report:
 
 **Proof Size Estimate:** 175 KiB, where 1 KiB = 1024 bytes
 
-| regime | total | ALI | DEEP | FRI batching round | FRI commit rounds (×7) | FRI query phase |
-| --- | --- | --- | --- | --- | --- | --- |
-| UDR | 38 | 121 | 106 | 100 | 105 | 38 |
-| JBR | 55 | 115 | 101 | 77 | 98 | 55 |
-| best attack | 96 | — | — | — | — | — |
+| regime | total | ALI | DEEP | FRI batching round | FRI commit round 1 | FRI commit round 2 | FRI commit round 3 | FRI commit round 4 | FRI commit round 5 | FRI commit round 6 | FRI commit round 7 | FRI query phase |
+| --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- |
+| UDR | 38 | 121 | 106 | 100 | 107 | 109 | 111 | 113 | 115 | 117 | 119 | 38 |
+| JBR | 55 | 115 | 101 | 76 | 83 | 85 | 87 | 89 | 91 | 93 | 95 | 55 |
+| best attack | 96 | — | — | — | — | — | — | — | — | — | — | — |
 
 ## RISC0
 
@@ -73,11 +73,11 @@ How to read this report:
 
 **Proof Size Estimate:** 576 KiB, where 1 KiB = 1024 bytes
 
-| regime | total | ALI | DEEP | FRI batching round | FRI commit rounds (×4) | FRI query phase |
-| --- | --- | --- | --- | --- | --- | --- |
-| UDR | 33 | 115 | 100 | 92 | 96 | 33 |
-| JBR | 47 | 110 | 95 | 70 | 90 | 47 |
-| best attack | 99 | — | — | — | — | — |
+| regime | total | ALI | DEEP | FRI batching round | FRI commit round 1 | FRI commit round 2 | FRI commit round 3 | FRI commit round 4 | FRI query phase |
+| --- | --- | --- | --- | --- | --- | --- | --- | --- | --- |
+| UDR | 33 | 115 | 100 | 92 | 100 | 104 | 108 | 112 | 33 |
+| JBR | 47 | 110 | 95 | 69 | 78 | 82 | 86 | 90 | 47 |
+| best attack | 99 | — | — | — | — | — | — | — | — |
 
 ## DummyWHIR
 

soundcalc/regimes/johnson_bound.py

@@ -104,11 +104,12 @@ def get_commit_phase_error(self, params: FRIParameters, round_idx: int) -> float
 
         # Compute accumulated folding factor up to round_idx
         # TODO: This assumes all folding factors are the same. Generalize!!
+        folding_factor = params.folding_factor
         acc_folding_factor = 1
         for i in range(round_idx + 1):
-            acc_folding_factor *= params.folding_factor
+            acc_folding_factor *= folding_factor
 
-        error *= (params.folding_factor - 1) / acc_folding_factor
+        error *= (folding_factor - 1) / acc_folding_factor
         return error
 
 

soundcalc/regimes/unique_decoding.py

@@ -57,9 +57,15 @@ def get_commit_phase_error(self, params: FRIParameters, round_idx: int) -> float
         """
         Returns the error for the FRI commit phase for this regime.
         """
-        D = params.D
-        FRI_folding_factor = params.folding_factor
-        F = params.F
 
-        fri_folding_error = (D * (FRI_folding_factor - 1)) / F
-        return fri_folding_error
+        error = params.D / params.F
+
+        # Compute accumulated folding factor up to round_idx
+        # TODO: This assumes all folding factors are the same. Generalize!!
+        folding_factor = params.folding_factor
+        acc_folding_factor = 1
+        for i in range(round_idx + 1):
+            acc_folding_factor *= folding_factor
+
+        error *= (folding_factor - 1) / acc_folding_factor
+        return error

soundcalc/zkvms/zisk.py

@@ -13,13 +13,11 @@ def default() -> "ZiskPreset":
 
         For ZisK, we populate the trace parameters from its constraint description:
             https://github.com/0xPolygonHermez/zisk/blob/main/pil/zisk.pil
-
-        The rest of the parameters are adapted from the "eSTARK: Extending STARKs with Arguments" paper:
-           https://eprint.iacr.org/2023/474
         """
 
         # We generate a STARK proof of different traces with different parameters.
-        # Therefore, in what follows, I put the parameters for our worst-case trace in terms of area.
+        # Therefore, in what follows, we put the parameters for our worst-case trace
+        # in terms of columns and batch size.
 
         # The blowup factor is dinamically chosen by this tool:
         #       https://github.com/0xPolygonHermez/pil2-proofman-js/blob/main/src/pil2-stark/pil_info/imPolsCalculation/imPolynomials.js#L96
@@ -29,12 +27,12 @@ def default() -> "ZiskPreset":
         rho = 1 / blowup_factor
 
         trace_length = 1 << 16
-        num_columns = 3022
+        num_columns = 3024
         batch_size = 4065
 
-        num_queries = 128 // int(math.log2(blowup_factor))
+        num_queries = 128
 
-        AIR_max_degree = blowup_factor + 1
+        AIR_max_degree = 3
 
         FRI_folding_factor = 2**4
         FRI_early_stop_degree = 2**5