This seems like a disconnect between get_builtin_globals_docs and the LSP infrastructure; almost seems like LspContext is missing a get_global_symbol_docs function to match the get_url_for_global_symbol, or perhaps the latter needs to be replaced with one that gives docs as well, idk.

Either way it is definitely that the LSP is not correctly resolving global symbols here:

buck2/starlark-rust/starlark_lsp/src/server.rs

Lines 1158 to 1171 in 71e819e

    
           IdentifierDefinition::Unresolved { source, name } => { 
        
               // Try to resolve as a global symbol. 
        
               self.context 
        
                   .get_environment(document_uri) 
        
                   .members 
        
                   .into_iter() 
        
                   .find(|symbol| symbol.0 == name) 
        
                   .map(|symbol| Hover { 
        
                       contents: HoverContents::Array(vec![MarkedString::String( 
        
                           render_doc_item_no_link(&symbol.0, &symbol.1), 
        
                       )]), 
        
                       range: Some(source.into()), 
        
                   }) 
        
           }

get_environment returns an empty value, thus the symbol doesn't resolve, thus the docs aren't there. In spite of this the buck2 lsp infra has some docs stuff for builtins, it's just not used in a manner that works.

	IdentifierDefinition::Unresolved { source, name } => {
	// Try to resolve as a global symbol.
	self.context
	.get_environment(document_uri)
	.members
	.into_iter()
	.find(\|symbol\| symbol.0 == name)
	.map(\|symbol\| Hover {
	contents: HoverContents::Array(vec![MarkedString::String(
	render_doc_item_no_link(&symbol.0, &symbol.1),
	)]),
	range: Some(source.into()),
	})
	}

LSP: hover docs for builtins #952

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions