Skip to content

Commit e723116

Browse files
authored
fix: only render secondaryMenu if it should be shown
fixes #10704 Issue was that with keyboard, you could reach the primary menu, while it was made invisible by CSS. By not rendering secondaryMenu based on the secondaryMenuShown logic, , we make sure it isn't accessible by keyboard while it is hidden.
1 parent 90e85e8 commit e723116

File tree

1 file changed

+7
-8
lines changed
  • packages/docusaurus-theme-classic/src/theme/Navbar/MobileSidebar/Layout

1 file changed

+7
-8
lines changed

packages/docusaurus-theme-classic/src/theme/Navbar/MobileSidebar/Layout/index.tsx

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,12 @@ export default function NavbarMobileSidebarLayout({
1919
return (
2020
<div className="navbar-sidebar">
2121
{header}
22-
<div
23-
className={clsx('navbar-sidebar__items', {
24-
'navbar-sidebar__items--show-secondary': secondaryMenuShown,
25-
})}>
26-
<div className="navbar-sidebar__item menu">{primaryMenu}</div>
27-
<div className="navbar-sidebar__item menu">{secondaryMenu}</div>
28-
</div>
29-
</div>
22+
<div className={clsx('navbar-sidebar__items')}>
23+
{secondaryMenuShown ? (
24+
<div className="navbar-sidebar__item menu">{secondaryMenu}</div>
25+
) : (
26+
<div className="navbar-sidebar__item menu">{primaryMenu}</div>
27+
)}
28+
</div>
3029
);
3130
}

0 commit comments

Comments
 (0)