Fix: Clear unmapped attribute banner when attribute is deleted

Author: David Evbodaghe

includes/Admin/Global_Attributes_Banner.php

@@ -135,12 +135,12 @@ private function is_attribute_taxonomy( $taxonomy ) {
 	}
 
 	/**
-	 * Check if a WooCommerce attribute still exists.
+	 * Check if a WooCommerce taxonomy attribute still exists.
 	 *
 	 * @param string $attribute_name Attribute name (without pa_ prefix).
-	 * @return bool True if the attribute exists, false otherwise.
+	 * @return bool True if the taxonomy attribute exists, false otherwise.
 	 */
-	private function attribute_exists( $attribute_name ) {
+	private function taxonomy_attribute_exists( $attribute_name ) {
 		// Check if the taxonomy exists (attributes use pa_{name} taxonomy)
 		$taxonomy_name = 'pa_' . $attribute_name;
 
@@ -223,7 +223,7 @@ public function display_unmapped_attribute_banner() {
 		$attribute_name = $banner_data['attribute_name'];
 
 		// Check if the attribute still exists - if deleted, clear transient and return early
-		if ( ! $this->attribute_exists( $attribute_name ) ) {
+		if ( ! $this->taxonomy_attribute_exists( $attribute_name ) ) {
 			delete_transient( 'fb_new_unmapped_attribute_banner' );
 			delete_transient( 'fb_show_banner_now' );
 			return;