Remove unused RCTHermesInstance field (#53858)

Summary:
Pull Request resolved: #53858

We only use static methods from `HermesInstance`

Changelog: [Internal]

Reviewed By: christophpurrer

Differential Revision: D82816061

fbshipit-source-id: 515dad2e8d6e0a6f6ac26f93d5a86aedf875f93e

Author: javache

packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTHermesInstance.h

@@ -5,27 +5,28 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-#import <UIKit/UIKit.h>
-
-#import <cxxreact/MessageQueueThread.h>
 #import <hermes/Public/CrashManager.h>
 #import <jsi/jsi.h>
 #import <react/runtime/JSRuntimeFactory.h>
-#import <react/runtime/hermes/HermesInstance.h>
 
 namespace facebook::react {
 
+class MessageQueueThread;
+
 using CrashManagerProvider =
     std::function<std::shared_ptr<::hermes::vm::CrashManager>()>;
 
 // ObjC++ wrapper for HermesInstance.cpp
 class RCTHermesInstance : public JSRuntimeFactory {
  public:
-  RCTHermesInstance();
-  RCTHermesInstance(CrashManagerProvider crashManagerProvider);
+  RCTHermesInstance() : RCTHermesInstance(nullptr, false) {}
+  RCTHermesInstance(CrashManagerProvider crashManagerProvider)
+      : RCTHermesInstance(std::move(crashManagerProvider), false) {}
   RCTHermesInstance(
       CrashManagerProvider crashManagerProvider,
-      bool allocInOldGenBeforeTTI);
+      bool allocInOldGenBeforeTTI)
+      : _crashManagerProvider(std::move(crashManagerProvider)),
+        _allocInOldGenBeforeTTI(allocInOldGenBeforeTTI) {}
 
   std::unique_ptr<JSRuntime> createJSRuntime(
       std::shared_ptr<MessageQueueThread> msgQueueThread) noexcept override;
@@ -34,7 +35,6 @@ class RCTHermesInstance : public JSRuntimeFactory {
 
  private:
   CrashManagerProvider _crashManagerProvider;
-  std::unique_ptr<HermesInstance> _hermesInstance;
   bool _allocInOldGenBeforeTTI;
 };
 

packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTHermesInstance.mm

@@ -7,26 +7,14 @@
 
 #import "RCTHermesInstance.h"
 
-namespace facebook::react {
-
-RCTHermesInstance::RCTHermesInstance() : RCTHermesInstance(nullptr, false) {}
-
-RCTHermesInstance::RCTHermesInstance(CrashManagerProvider crashManagerProvider)
-    : RCTHermesInstance(std::move(crashManagerProvider), false)
-{
-}
+#import <react/runtime/hermes/HermesInstance.h>
 
-RCTHermesInstance::RCTHermesInstance(CrashManagerProvider crashManagerProvider, bool allocInOldGenBeforeTTI)
-    : _crashManagerProvider(std::move(crashManagerProvider)),
-      _hermesInstance(std::make_unique<HermesInstance>()),
-      _allocInOldGenBeforeTTI(allocInOldGenBeforeTTI)
-{
-}
+namespace facebook::react {
 
 std::unique_ptr<JSRuntime> RCTHermesInstance::createJSRuntime(
     std::shared_ptr<MessageQueueThread> msgQueueThread) noexcept
 {
-  return facebook::react::HermesInstance::createJSRuntime(
+  return HermesInstance::createJSRuntime(
       _crashManagerProvider ? _crashManagerProvider() : nullptr, std::move(msgQueueThread), _allocInOldGenBeforeTTI);
 }