Skip to content

Commit 6b493d8

Browse files
committed
Misc cleanup
1 parent 6594e86 commit 6b493d8

File tree

4 files changed

+13
-9
lines changed

4 files changed

+13
-9
lines changed

src/omnipy/modules/json/tasks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
from omnipy.compute.task import TaskTemplate
55
from omnipy.compute.typing import mypy_fix_task_template
66
from omnipy.data.dataset import Dataset
7+
from omnipy.data.helpers import obj_or_model_contents_isinstance
78
from omnipy.data.model import Model
89

9-
from ...data.helpers import obj_or_model_contents_isinstance
1010
from .datasets import (JsonDataset,
1111
JsonDictDataset,
1212
JsonListDataset,

src/omnipy/modules/pandas/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
from typing import Any
33

44
from omnipy.data.dataset import Dataset
5+
from omnipy.data.helpers import is_model_instance
56
from omnipy.data.model import Model
67

78
from . import pd
8-
from ...data.helpers import is_model_instance
99
from ..tables.models import TableListOfDictsOfJsonScalarsModel
1010

1111

src/omnipy/modules/raw/tasks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
from omnipy.compute.task import TaskTemplate
1313
from omnipy.compute.typing import mypy_fix_task_template
1414
from omnipy.data.dataset import Dataset, Model
15+
from omnipy.util.setdeque import SetDeque
1516

16-
from ...util.setdeque import SetDeque
1717
from .datasets import StrDataset
1818
from .protocols import IsModifyAllLinesCallable, IsModifyContentsCallable, IsModifyEachLineCallable
1919

src/omnipy/modules/tables/models.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,19 +37,23 @@ def _parse_data(
3737
if isinstance(data[0], list): # type: ignore[index]
3838
first_row_as_colnames = Model[list[str]](data[0]) # type: ignore[index]
3939
first_row_as_colnames_data: list[str] = \
40-
first_row_as_colnames.to_data()
40+
first_row_as_colnames.to_data() # type: ignore[assignment]
4141

42-
return [{
43-
col_name: row[i] if i < len(row) else None for i,
44-
col_name in enumerate(first_row_as_colnames_data)
45-
} for j,
46-
row in enumerate(data) if j > 0]
42+
return cls._convert_list_of_lists_to_list_of_dicts(data, first_row_as_colnames_data)
4743
else:
4844
assert isinstance(data[0], dict) # type: ignore[index]
4945
return cast(TableListOfDictsOfJsonScalarsModel, data)
5046

5147
return cast(TableListOfDictsOfJsonScalarsModel, data)
5248

49+
@classmethod
50+
def _convert_list_of_lists_to_list_of_dicts(cls, data, first_row_as_colnames_data):
51+
return [{
52+
col_name: row[i] if i < len(row) else None for i,
53+
col_name in enumerate(first_row_as_colnames_data)
54+
} for j,
55+
row in enumerate(data) if j > 0]
56+
5357
@property
5458
def col_names(self) -> tuple[str]:
5559
col_names = {}

0 commit comments

Comments
 (0)