wip

Author: nyurik

.github/workflows/ci.yml

@@ -22,12 +22,7 @@ jobs:
         uses: Swatinem/rust-cache@v2
       - uses: taiki-e/install-action@v2
         with: { tool: 'just,cargo-binstall' }
-      - if: github.event_name == 'release'
-        name: Ensure this crate has not yet been published (on release)
-        run: just check-if-published
       - run: just ci-test
-      - name: Check semver
-        uses: obi1kenobi/cargo-semver-checks-action@v2
 
   test-nightly:
     name: Nightly-specific tests

Cargo.toml

@@ -45,6 +45,4 @@ cast_sign_loss = "allow"
 missing_errors_doc = "allow"
 missing_panics_doc = "allow"
 must_use_candidate = "allow"
-needless_range_loop = "allow"
-precedence = "allow"
 unreadable_literal = "allow"

justfile

@@ -7,6 +7,9 @@ features_flag := '--all-features'
 # Use `CI=true just ci-test` to run the same tests as in GitHub CI.
 # Use `just env-info` to see the current values of RUSTFLAGS and RUSTDOCFLAGS
 ci_mode := if env('CI', '') != '' {'1'} else {''}
+# cargo-binstall needs a workaround due to caching
+# ci_mode might be manually set by user, so re-check the env var
+binstall_args := if env('CI', '') != '' {'--no-track'} else {''}
 export RUSTFLAGS := env('RUSTFLAGS', if ci_mode == '1' {'-D warnings'} else {''})
 export RUSTDOCFLAGS := env('RUSTDOCFLAGS', if ci_mode == '1' {'-D warnings'} else {''})
 export RUST_BACKTRACE := env('RUST_BACKTRACE', if ci_mode == '1' {'1'} else {''})
@@ -16,7 +19,7 @@ export RUST_BACKTRACE := env('RUST_BACKTRACE', if ci_mode == '1' {'1'} else {''}
 
 # Run integration tests and save its output as the new expected output
 bless *args:  (cargo-install 'cargo-insta')
-    TRYBUILD=overwrite cargo insta test --accept --unreferenced=delete --all-features
+    cargo insta test --accept --unreferenced=delete {{features_flag}} {{args}}
 
 # Build the project
 build:
@@ -58,6 +61,7 @@ docs *args='--open':
 # Print environment info
 env-info:
     @echo "Running {{if ci_mode == '1' {'in CI mode'} else {'in dev mode'} }} on {{os()}} / {{arch()}}"
+    @echo "PWD $(pwd)"
     {{just_executable()}} --version
     rustc --version
     cargo --version
@@ -93,6 +97,7 @@ get-msrv package=main_crate:  (get-crate-field 'rust_version' package)
 msrv:  (cargo-install 'cargo-msrv')
     cargo msrv find --write-msrv --component rustfmt {{features_flag}} --ignore-lockfile -- {{just_executable()}} ci-test-msrv
 
+# Run cargo-release
 release *args='':  (cargo-install 'release-plz')
     release-plz {{args}}
 
@@ -112,6 +117,10 @@ test-doc:  (docs '')
 test-fmt: && (fmt-toml '--check' '--check-format')
     cargo fmt --all -- --check
 
+# Use the experimental workspace publishing with --dry-run. Requires nightly Rust.
+test-publish:
+    cargo +nightly -Z package-workspace publish --dry-run
+
 # Find unused dependencies. Install it with `cargo install cargo-udeps`
 udeps:  (cargo-install 'cargo-udeps')
     cargo +nightly udeps --workspace --all-targets {{features_flag}}
@@ -150,7 +159,7 @@ cargo-install $COMMAND $INSTALL_CMD='' *args='':
             echo "$COMMAND could not be found. Installing it with    cargo install ${INSTALL_CMD:-$COMMAND} --locked {{args}}"
             cargo install ${INSTALL_CMD:-$COMMAND} --locked {{args}}
         else
-            echo "$COMMAND could not be found. Installing it with    cargo binstall ${INSTALL_CMD:-$COMMAND} --locked {{args}}"
-            cargo binstall ${INSTALL_CMD:-$COMMAND} --locked {{args}}
+            echo "$COMMAND could not be found. Installing it with    cargo binstall ${INSTALL_CMD:-$COMMAND} {{binstall_args}} --locked {{args}}"
+            cargo binstall ${INSTALL_CMD:-$COMMAND} {{binstall_args}} --locked {{args}}
         fi
     fi

src/rust/bytebuffer.rs

@@ -107,8 +107,8 @@ impl IntBuffer {
         // FIXME: why is self not used here??
         assert!(offset + length as usize <= src.len(), "Buffer underflow");
         let mut result: Vec<u8> = vec![];
-        for i in offset..offset + length as usize {
-            result.extend_from_slice(&src[i].to_le_bytes());
+        for value in &src[offset..offset + (length as usize)] {
+            result.extend_from_slice(&value.to_le_bytes());
         }
         result
     }

src/rust/integer_compression/bitpacking.rs

@@ -1339,9 +1339,7 @@ pub fn fast_unpack(input: &[u32], inpos: usize, output: &mut [u32], outpos: usiz
 }
 
 fn fast_unpack0(output: &mut [u32], outpos: usize) {
-    for i in outpos..outpos + 32 {
-        output[i] = 0;
-    }
+    output[outpos..outpos + 32].fill(0);
 }
 
 fn fast_unpack1(input: &[u32], inpos: usize, output: &mut [u32], outpos: usize) {

tests/basic_tests.rs

@@ -1,4 +1,5 @@
 #![cfg(feature = "rust")]
+#![allow(clippy::needless_range_loop)]
 
 use std::io::Cursor;
 
@@ -36,7 +37,7 @@ fn saul_test() {
                     &mut output_offset,
                 )
                 .unwrap_or_else(|e| {
-                    panic!("Failed to compress with {}: {:?}", codec.name(), e);
+                    panic!("Failed to compress with {}: {e:?}", codec.name());
                 });
 
             let len = output_offset.position() as u32 - x;
@@ -51,7 +52,7 @@ fn saul_test() {
                     &mut Cursor::new(0),
                 )
                 .unwrap_or_else(|e| {
-                    panic!("Failed to uncompress with {}: {:?}", codec.name(), e);
+                    panic!("Failed to uncompress with {}: {e:?}", codec.name());
                 });
 
             assert_eq!(input, answer);
@@ -81,7 +82,7 @@ fn test_varying_length() {
                     &mut Cursor::new(0),
                 )
                 .unwrap_or_else(|e| {
-                    panic!("Failed to compress with {}: {:?}", codec.name(), e);
+                    panic!("Failed to compress with {}: {e:?}", codec.name());
                 });
             let mut answer = vec![0; l + 1024];
             codec
@@ -93,7 +94,7 @@ fn test_varying_length() {
                     &mut Cursor::new(0),
                 )
                 .unwrap_or_else(|e| {
-                    panic!("Failed to uncompress with {}: {:?}", codec.name(), e);
+                    panic!("Failed to uncompress with {}: {e:?}", codec.name());
                 });
             for k in 0..l {
                 assert_eq!(answer[k], data[k]);
@@ -122,7 +123,7 @@ fn test_varying_length_two() {
                     &mut Cursor::new(0),
                 )
                 .unwrap_or_else(|e| {
-                    panic!("Failed to compress with {}: {:?}", codec.name(), e);
+                    panic!("Failed to compress with {}: {e:?}", codec.name());
                 });
             let mut answer = vec![0; data_copy.len() + 1024];
             codec
@@ -134,7 +135,7 @@ fn test_varying_length_two() {
                     &mut Cursor::new(0),
                 )
                 .unwrap_or_else(|e| {
-                    panic!("Failed to uncompress with {}: {:?}", codec.name(), e);
+                    panic!("Failed to uncompress with {}: {e:?}", codec.name());
                 });
             for k in 1..l {
                 if answer[k] != data[k] {

tomlfmt.toml

@@ -0,0 +1,13 @@
+table_order = [
+    'package',
+    'lib',
+    'bin',
+    'example',
+    'bench',
+    'features',
+    'dependencies',
+    'build-dependencies',
+    'dev-dependencies',
+    'profile',
+    'lints',
+]