Skip to content

Commit e9483f3

Browse files
committed
Fix broken unit tests #1780
1 parent c539db8 commit e9483f3

File tree

2 files changed

+18
-14
lines changed

2 files changed

+18
-14
lines changed
Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,23 @@
1-
from unittest.mock import MagicMock, patch
1+
from unittest.mock import MagicMock, Mock, patch
22

33
from sqlmodel import select
44

5+
import app.backend_pre_start
56
from app.backend_pre_start import init, logger
67

78

89
def test_init_successful_connection() -> None:
910
engine_mock = MagicMock()
1011

1112
session_mock = MagicMock()
12-
exec_mock = MagicMock(return_value=True)
13-
session_mock.configure_mock(**{"exec.return_value": exec_mock})
13+
session_mock.__enter__.return_value = session_mock
14+
session_mock.exec = Mock()
15+
16+
select1 = select(1)
1417

1518
with (
16-
patch("sqlmodel.Session", return_value=session_mock),
19+
patch("app.backend_pre_start.Session", return_value=session_mock),
20+
patch("app.backend_pre_start.select", return_value=select1),
1721
patch.object(logger, "info"),
1822
patch.object(logger, "error"),
1923
patch.object(logger, "warn"),
@@ -28,6 +32,4 @@ def test_init_successful_connection() -> None:
2832
connection_successful
2933
), "The database connection should be successful and not raise an exception."
3034

31-
assert session_mock.exec.called_once_with(
32-
select(1)
33-
), "The session should execute a select statement once."
35+
session_mock.exec.assert_called_once_with(select1)
Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,23 @@
1-
from unittest.mock import MagicMock, patch
1+
from unittest.mock import MagicMock, Mock, patch
22

33
from sqlmodel import select
44

5+
import app.tests_pre_start
56
from app.tests_pre_start import init, logger
67

78

89
def test_init_successful_connection() -> None:
910
engine_mock = MagicMock()
1011

1112
session_mock = MagicMock()
12-
exec_mock = MagicMock(return_value=True)
13-
session_mock.configure_mock(**{"exec.return_value": exec_mock})
13+
session_mock.__enter__.return_value = session_mock
14+
session_mock.exec = Mock()
15+
16+
select1 = select(1)
1417

1518
with (
16-
patch("sqlmodel.Session", return_value=session_mock),
19+
patch("app.tests_pre_start.Session", return_value=session_mock),
20+
patch("app.tests_pre_start.select", return_value=select1),
1721
patch.object(logger, "info"),
1822
patch.object(logger, "error"),
1923
patch.object(logger, "warn"),
@@ -28,6 +32,4 @@ def test_init_successful_connection() -> None:
2832
connection_successful
2933
), "The database connection should be successful and not raise an exception."
3034

31-
assert session_mock.exec.called_once_with(
32-
select(1)
33-
), "The session should execute a select statement once."
35+
session_mock.exec.assert_called_once_with(select1)

0 commit comments

Comments
 (0)