Skip to content

Commit 4a8437c

Browse files
authored
Merge pull request #300 from faster-cpython/dont-persist-credentials
Based on zizmor linting: Don't persist credentials when not necessary
2 parents a04cb14 + e15f2f6 commit 4a8437c

File tree

7 files changed

+20
-0
lines changed

7 files changed

+20
-0
lines changed

bench_runner/templates/_benchmark.src.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ jobs:
7777
- name: Checkout CPython
7878
uses: actions/checkout@v4
7979
with:
80+
persist-credentials: false
8081
repository: ${{ inputs.fork }}/cpython
8182
path: cpython
8283
ref: ${{ inputs.ref }}
@@ -96,13 +97,15 @@ jobs:
9697
uses: actions/checkout@v4
9798
if: ${{ steps.should_run.outputs.should_run != 'false' }}
9899
with:
100+
persist-credentials: false
99101
repository: pyston/python-macrobenchmarks
100102
path: pyston-benchmarks
101103
ref: ${{ env.PYSTON_BENCHMARKS_HASH }}
102104
- name: Checkout pyperformance
103105
uses: actions/checkout@v4
104106
if: ${{ steps.should_run.outputs.should_run != 'false' }}
105107
with:
108+
persist-credentials: false
106109
repository: mdboom/pyperformance
107110
path: pyperformance
108111
ref: ${{ env.PYPERFORMANCE_HASH }}
@@ -163,6 +166,7 @@ jobs:
163166
- name: Checkout CPython
164167
uses: actions/checkout@v4
165168
with:
169+
persist-credentials: false
166170
repository: ${{ inputs.fork }}/cpython
167171
path: cpython
168172
ref: ${{ inputs.ref }}
@@ -182,13 +186,15 @@ jobs:
182186
uses: actions/checkout@v4
183187
if: ${{ steps.should_run.outputs.should_run != 'false' }}
184188
with:
189+
persist-credentials: false
185190
repository: pyston/python-macrobenchmarks
186191
path: pyston-benchmarks
187192
ref: ${{ env.PYSTON_BENCHMARKS_HASH }}
188193
- name: Checkout pyperformance
189194
uses: actions/checkout@v4
190195
if: ${{ steps.should_run.outputs.should_run != 'false' }}
191196
with:
197+
persist-credentials: false
192198
repository: mdboom/pyperformance
193199
path: pyperformance
194200
ref: ${{ env.PYPERFORMANCE_HASH }}
@@ -257,6 +263,7 @@ jobs:
257263
- name: Checkout CPython
258264
uses: actions/checkout@v4
259265
with:
266+
persist-credentials: false
260267
repository: ${{ inputs.fork }}/cpython
261268
path: cpython
262269
ref: ${{ inputs.ref }}
@@ -276,13 +283,15 @@ jobs:
276283
uses: actions/checkout@v4
277284
if: ${{ steps.should_run.outputs.should_run != 'false' }}
278285
with:
286+
persist-credentials: false
279287
repository: pyston/python-macrobenchmarks
280288
path: pyston-benchmarks
281289
ref: ${{ env.PYSTON_BENCHMARKS_HASH }}
282290
- name: Checkout pyperformance
283291
uses: actions/checkout@v4
284292
if: ${{ steps.should_run.outputs.should_run != 'false' }}
285293
with:
294+
persist-credentials: false
286295
repository: mdboom/pyperformance
287296
path: pyperformance
288297
ref: ${{ env.PYPERFORMANCE_HASH }}

bench_runner/templates/_generate.src.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ jobs:
3333
- name: Checkout CPython
3434
uses: actions/checkout@v4
3535
with:
36+
persist-credentials: false
3637
repository: python/cpython
3738
path: cpython
3839
- name: Setup system Python

bench_runner/templates/_notify.src.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ jobs:
2222
- uses: technote-space/workflow-conclusion-action@v3
2323
- name: Checkout benchmarking
2424
uses: actions/checkout@v4
25+
with:
26+
persist-credentials: false
2527
- name: Setup system Python
2628
uses: actions/setup-python@v5
2729
with:

bench_runner/templates/_publish.src.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ jobs:
2222
- name: Checkout benchmarking
2323
uses: actions/checkout@v4
2424
with:
25+
persist-credentials: false
2526
path: private
2627
ref: main
2728
fetch-depth: 0

bench_runner/templates/_pystats.src.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ jobs:
5959
- name: Checkout CPython
6060
uses: actions/checkout@v4
6161
with:
62+
persist-credentials: false
6263
repository: ${{ inputs.fork }}/cpython
6364
ref: ${{ inputs.ref }}
6465
path: cpython
@@ -77,13 +78,15 @@ jobs:
7778
uses: actions/checkout@v4
7879
if: ${{ steps.should_run.outputs.should_run != 'false' }}
7980
with:
81+
persist-credentials: false
8082
repository: pyston/python-macrobenchmarks
8183
path: pyston-benchmarks
8284
ref: ${{ env.PYSTON_BENCHMARKS_HASH }}
8385
- name: Checkout pyperformance
8486
uses: actions/checkout@v4
8587
if: ${{ steps.should_run.outputs.should_run != 'false' }}
8688
with:
89+
persist-credentials: false
8790
repository: mdboom/pyperformance
8891
path: pyperformance
8992
ref: ${{ env.PYPERFORMANCE_HASH }}

bench_runner/templates/_weekly.src.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ jobs:
1818
- name: Checkout CPython
1919
uses: actions/checkout@v4
2020
with:
21+
persist-credentials: false
2122
repository: python/cpython
2223
path: cpython
2324
ref: main

bench_runner/templates/benchmark.src.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@ jobs:
4747
steps:
4848
- name: Checkout benchmarking
4949
uses: actions/checkout@v4
50+
with:
51+
persist-credentials: false
5052
- name: Setup system Python
5153
uses: actions/setup-python@v5
5254
with:
@@ -55,6 +57,7 @@ jobs:
5557
- name: Checkout CPython
5658
uses: actions/checkout@v4
5759
with:
60+
persist-credentials: false
5861
repository: ${{ inputs.fork }}/cpython
5962
path: cpython
6063
ref: ${{ inputs.ref }}

0 commit comments

Comments
 (0)