Skip to content

Commit 7fe47ab

Browse files
authored
perf: use node: prefix to bypass require.cache call for builtins (#658)
* perf: use `node:` prefix to bypass require.cache call for builtins See fastify/fastify-static#407 * test(start): fix mock
1 parent a8a34f6 commit 7fe47ab

24 files changed

+65
-65
lines changed

cli.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
'use strict'
44

5-
const path = require('path')
5+
const path = require('node:path')
66
const commist = require('commist')()
77
const argv = require('yargs-parser')(process.argv)
88
const help = require('help-me')({

eject.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict'
22

3-
const path = require('path')
3+
const path = require('node:path')
44
const generify = require('generify')
55
const argv = require('yargs-parser')
66
const log = require('./log')

generate-plugin.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@
33
const {
44
readFile,
55
writeFile
6-
} = require('fs').promises
7-
const { existsSync } = require('fs')
8-
const path = require('path')
6+
} = require('node:fs').promises
7+
const { existsSync } = require('node:fs')
8+
const path = require('node:path')
99
const chalk = require('chalk')
1010
const generify = require('generify')
1111
const argv = require('yargs-parser')
1212
const cliPkg = require('./package')
13-
const { execSync } = require('child_process')
14-
const { promisify } = require('util')
13+
const { execSync } = require('node:child_process')
14+
const { promisify } = require('node:util')
1515
const log = require('./log')
1616

1717
const pluginTemplate = {

generate-readme.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
'use strict'
22

3-
const { readFileSync, existsSync } = require('fs')
4-
const path = require('path')
3+
const { readFileSync, existsSync } = require('node:fs')
4+
const path = require('node:path')
55
const generify = require('generify')
66
const argv = require('yargs-parser')
7-
const { execSync } = require('child_process')
7+
const { execSync } = require('node:child_process')
88
const log = require('./log')
99

1010
function toMarkdownList (a) {

generate.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@ const {
44
readFile,
55
writeFile,
66
existsSync
7-
} = require('fs')
8-
const path = require('path')
7+
} = require('node:fs')
8+
const path = require('node:path')
99
const chalk = require('chalk')
1010
const generify = require('generify')
1111
const argv = require('yargs-parser')
1212
const cliPkg = require('./package')
13-
const { execSync } = require('child_process')
13+
const { execSync } = require('node:child_process')
1414
const log = require('./log')
1515

1616
const javascriptTemplate = {

lib/watch/index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
'use strict'
22

3-
const path = require('path')
4-
const cp = require('child_process')
3+
const path = require('node:path')
4+
const cp = require('node:child_process')
55
const chalk = require('chalk')
66
const { arrayToRegExp, logWatchVerbose } = require('./utils')
77
const { GRACEFUL_SHUT } = require('./constants.js')
88

9-
const EventEmitter = require('events')
9+
const EventEmitter = require('node:events')
1010
const chokidar = require('chokidar')
1111
const forkPath = path.join(__dirname, './fork.js')
1212

lib/watch/utils.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict'
22

33
const chalk = require('chalk')
4-
const path = require('path')
4+
const path = require('node:path')
55

66
const arrayToRegExp = (arr) => {
77
const reg = arr.map((file) => {

start.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ async function runFastify (args, additionalOptions, serverOptions) {
124124
if (process.version.match(/v[0-6]\..*/g)) {
125125
stop('Fastify debug mode not compatible with Node.js version < 6')
126126
} else {
127-
require('inspector').open(
127+
require('node:inspector').open(
128128
opts.debugPort,
129129
opts.debugHost || isDocker() || isKubernetes() ? listenAddressDocker : undefined
130130
)

templates/app/app.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict'
22

3-
const path = require('path')
3+
const path = require('node:path')
44
const AutoLoad = require('@fastify/autoload')
55

66
// Pass --options via CLI arguments in command to enable these options.

templates/app/test/helper.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// between our tests.
55

66
const { build: buildApplication } = require('fastify-cli/helper')
7-
const path = require('path')
7+
const path = require('node:path')
88
const AppPath = path.join(__dirname, '..', 'app.js')
99

1010
// Fill in this config with all the configurations

0 commit comments

Comments
 (0)