add tests

Author: simone-sanfratello

index.js

@@ -84,6 +84,15 @@ function noop () { }
 
 function proxyWebSockets (logger, source, target, hooks) {
   function close (code, reason) {
+    if (hooks.onDisconnect) {
+      waitConnection(target, () => {
+        try {
+          hooks.onDisconnect(source)
+        } catch (err) {
+          logger.error({ err }, 'proxy ws error from onDisconnect hook')
+        }
+      })
+    }
     closeWebSocket(source, code, reason)
     closeWebSocket(target, code, reason)
   }

test/websocket.js

@@ -769,4 +769,44 @@ test('should handle throwing an error in onIncomingMessage and onOutgoingMessage
   await waitForLogMessage(loggerSpy, 'proxy ws error from onOutgoingMessage hook')
 })
 
-// TODO onConnect, onDisconnect
+test('should call onConnect hook', async (t) => {
+  const onConnect = () => {
+    logger.info('onConnect called')
+  }
+
+  const { loggerSpy, logger } = await createServices({ t, wsHooks: { onConnect } })
+
+  await waitForLogMessage(loggerSpy, 'onConnect called')
+})
+
+test('should handle throwing an error in onConnect hook', async (t) => {
+  const onConnect = () => {
+    throw new Error('onConnect error')
+  }
+
+  const { loggerSpy } = await createServices({ t, wsHooks: { onConnect } })
+
+  await waitForLogMessage(loggerSpy, 'proxy ws error from onConnect hook')
+})
+
+test('should call onDisconnect hook', async (t) => {
+  const onDisconnect = () => {
+    logger.info('onDisconnect called')
+  }
+
+  const { loggerSpy, logger, client } = await createServices({ t, wsHooks: { onDisconnect } })
+  client.close()
+
+  await waitForLogMessage(loggerSpy, 'onDisconnect called')
+})
+
+test('should handle throwing an error in onDisconnect hook', async (t) => {
+  const onDisconnect = () => {
+    throw new Error('onDisconnect error')
+  }
+
+  const { loggerSpy, client } = await createServices({ t, wsHooks: { onDisconnect } })
+  client.close()
+
+  await waitForLogMessage(loggerSpy, 'proxy ws error from onDisconnect hook')
+})

test/ws-reconnect.js

@@ -268,4 +268,60 @@ test('should handle throwing an error in onIncomingMessage and onOutgoingMessage
   await waitForLogMessage(loggerSpy, 'proxy ws error from onOutgoingMessage hook')
 })
 
-// TODO onConnect, onDisconnect
+test('should call onConnect hook', async (t) => {
+  const onConnect = () => {
+    logger.info('onConnect called')
+  }
+
+  const wsReconnectOptions = {
+    logs: true,
+  }
+
+  const { loggerSpy, logger } = await createServices({ t, wsReconnectOptions, wsHooks: { onConnect } })
+
+  await waitForLogMessage(loggerSpy, 'onConnect called')
+})
+
+test('should handle throwing an error in onConnect hook', async (t) => {
+  const onConnect = () => {
+    throw new Error('onConnect error')
+  }
+
+  const wsReconnectOptions = {
+    logs: true,
+  }
+
+  const { loggerSpy } = await createServices({ t, wsReconnectOptions, wsHooks: { onConnect } })
+
+  await waitForLogMessage(loggerSpy, 'proxy ws error from onConnect hook')
+})
+
+test('should call onDisconnect hook', async (t) => {
+  const onDisconnect = () => {
+    logger.info('onDisconnect called')
+  }
+
+  const wsReconnectOptions = {
+    logs: true,
+  }
+
+  const { loggerSpy, logger, client } = await createServices({ t, wsReconnectOptions, wsHooks: { onDisconnect } })
+  client.close()
+
+  await waitForLogMessage(loggerSpy, 'onDisconnect called')
+})
+
+test('should handle throwing an error in onDisconnect hook', async (t) => {
+  const onDisconnect = () => {
+    throw new Error('onDisconnect error')
+  }
+
+  const wsReconnectOptions = {
+    logs: true,
+  }
+
+  const { loggerSpy, client } = await createServices({ t, wsReconnectOptions, wsHooks: { onDisconnect } })
+  client.close()
+
+  await waitForLogMessage(loggerSpy, 'proxy ws error from onDisconnect hook')
+})